[#31370] - [4.0] Remove IDs from URLs
- Fixed in Code Base
- 18 Dec 2020
- Medium
- Build: 4.0-dev
- # 31370
- Diff
- brianteeman:sef
User tests: Successful: Unsuccessful:
This PR changes the default value for this setting that is found in com_content, com_contact and com_newsfeeds from the old showing of IDs in the url to the much improved new way of not displaying them.
This is only for new installs. It will not change an updated site.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact com_content com_newsfeeds SQL Installation Postgresql |
I did a test with and without PR. The ID of the article and the contact, with the active PR, remains at the end of the URL and is what I see in the content area in the BackEnd.
Example
- URL: ~index.php/contact-uncategory/1-c
- BackEnd Screan:
Which ID are you talking about?
Its the id in the URL
@brianteeman If you change the default value in the XML, you also have to change the default values in the PHP files where the param is used. Those values always need to match. With your current code, the behavior would switch the moment the settings are saved, if there was no stored value for sef_ids before.
If you want to change it only for new installations, then it is sufficient to change only the installation SQL files. You have to leave the XML and PHP the way they are.
the behavior would switch the moment the settings are saved, if there was no stored value for sef_ids before.
Good spot - thanks
So just t confirm. By only changing the sql will mean - new installs default to "no id"
existing installs are not changed on update AND existing installs will not be changed when an unrelated setting is changed.
| Labels |
Added:
?
|
||
| Category | Administration com_contact com_content com_newsfeeds SQL Installation Postgresql | ⇒ | SQL Installation Postgresql |
Looks fine now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31370.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31370.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31370.
Any reason why this RTC pr has not been merged?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 02:59:44 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Just had missed it in the list of things. LGTM!
thx
I have not tested with a new install but I did look at what happens when the "Remove IDs from URLs" is changed manually - looks OK. And I changed the wording of the associated Help screens. It was:
and is now:
For newsfeed read article or contact or newsfeed. Is that correct?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31370.