Joomla! Issue Tracker | Joomla! CMS #31365 - [4.0] Fix category select in field editing form

? ?

Fixed in Code Base
9 Nov 2020
Medium
Build: 4.0-dev
# 31365
Diff
Fedik:fix-fields

Pending

User tests: Successful: Unsuccessful:

Fedik
8 Nov 2020

Pull Request for Issue #31352 .

Summary of Changes

This changes <option value="">JALL</option> to <option value="0">JALL</option>.

joomla-cms/administrator/components/com_fields/forms/field.xml

Lines 39 to 41 in 0e316b3

    
           > 
        
           <option value="">JALL</option> 
        
           <option value="-1">JNONE</option>

As it casts to 0 anyway, that should work fine.

joomla-cms/administrator/components/com_fields/src/Model/FieldModel.php

Lines 166 to 184 in d7451e6

    
           $cats = isset($data['assigned_cat_ids']) ? (array) $data['assigned_cat_ids'] : array(); 
        
           $cats = ArrayHelper::toInteger($cats); 
        
           $assignedCatIds = array(); 
        
           foreach ($cats as $cat) 
        
           { 
        
           	// If we have found the 'JNONE' category, remove all other from the result and break. 
        
           	if ($cat == '-1') 
        
           	{ 
        
           		$assignedCatIds = array('-1'); 
        
           		break; 
        
           	} 
        
           	if ($cat) 
        
           	{ 
        
           		$assignedCatIds[] = $cat; 
        
           	} 
        
           }

Also I have fixed placeholder text for a "multiple category" input.

Testing Instructions

Please look for detail #31352

Actual result BEFORE applying this Pull Request

you cannot select All

Expected result AFTER applying this Pull Request

you can select All

Documentation Changes Required

none

1075182 8 Nov 2020

fix category select in field editing form

Fedik - open - 8 Nov 2020

Fedik - change - 8 Nov 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 8 Nov 2020

Category

⇒

Administration com_categories com_fields

ChristineWk - test_item - 8 Nov 2020 - Tested successfully

ChristineWk - comment - 8 Nov 2020

I have tested this item ✅ successfully on 1075182

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31365.}

infograf768 - test_item - 8 Nov 2020 - Tested successfully

infograf768 - comment - 8 Nov 2020

I have tested this item ✅ successfully on 1075182

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31365.}

infograf768 - comment - 8 Nov 2020

Result:

richard67 - change - 8 Nov 2020

Status

Pending

⇒

Ready to Commit

richard67 - comment - 8 Nov 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31365.}

richard67 - change - 8 Nov 2020

Labels

Added: ? ?

chmst - change - 9 Nov 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-11-09 15:25:19
Closed_By		⇒	chmst
Labels

chmst - close - 9 Nov 2020

chmst - merge - 9 Nov 2020

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#31365] - [4.0] Fix category select in field editing form

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Add a Comment

	>
	<option value="">JALL</option>
	<option value="-1">JNONE</option>

	$cats = isset($data['assigned_cat_ids']) ? (array) $data['assigned_cat_ids'] : array();
	$cats = ArrayHelper::toInteger($cats);

	$assignedCatIds = array();

	foreach ($cats as $cat)
	{
	// If we have found the 'JNONE' category, remove all other from the result and break.
	if ($cat == '-1')
	{
	$assignedCatIds = array('-1');
	break;
	}

	if ($cat)
	{
	$assignedCatIds[] = $cat;
	}
	}