? ?
avatar brianteeman
brianteeman
7 Nov 2020

Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a newsfeed (you can use https://community.joomla.org/blogs/community.feed and in the options add a first and second image

image

Testing Part 2

Please test three scenarios when you display the newsfeed from the menu

  1. Image Description (Alt Text) = Empty
    No Description = unchecked

  2. Image Description (Alt Text) = "some description"
    No Description = unchecked

  3. Image Description (Alt Text) = Empty
    No Description = checked

The expected behaviour for each of these tests is

1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar brianteeman brianteeman - open - 7 Nov 2020
avatar richard67
richard67 - comment - 7 Nov 2020

Strange, this PR doesn't appear in the issue tracker.

avatar Quy
Quy - comment - 16 Nov 2020

Tested successfully.

avatar BertaOctech
BertaOctech - comment - 26 Nov 2020

Hi,
Is this issue waiting for tests?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357.

avatar alikon
alikon - comment - 26 Nov 2020

yes ?

avatar snehal0904
snehal0904 - comment - 5 Dec 2020

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357.

avatar richard67
richard67 - comment - 5 Dec 2020

@snehal0904 Could you mark your test result in the issue tracker? Just go to the PR here https://issues.joomla.org/tracker/joomla-cms/31357 , use the "Test this" button, select the appropriate test result and the submit. Thanks in advance.

avatar gostn
gostn - comment - 5 Dec 2020

@snehal0904 please mark your test as successfully at issue-tracker.

avatar snehal0904
snehal0904 - comment - 5 Dec 2020

@gostn I tried this but I don't know why for this particular issue Test this button is not present.

avatar gostn
gostn - comment - 5 Dec 2020

@snehal0904 you're right, there is no test this-button for this pr; don't know why.

avatar chmst chmst - change - 5 Dec 2020
Status New Pending
Labels Added: ?
avatar HLeithner HLeithner - change - 5 Dec 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-05 12:43:20
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 5 Dec 2020
avatar HLeithner HLeithner - merge - 5 Dec 2020
avatar HLeithner
HLeithner - comment - 5 Dec 2020

Thanks

avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2020
Category Administration com_newsfeeds Language & Strings Front End
avatar brianteeman
brianteeman - comment - 5 Dec 2020

thanks

Add a Comment

Login with GitHub to post a comment