Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
To read why this change is very important see #31318
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a newsfeed (you can use https://community.joomla.org/blogs/community.feed and in the options add a first and second image
Please test three scenarios when you display the newsfeed from the menu
Image Description (Alt Text) = Empty
No Description = unchecked
Image Description (Alt Text) = "some description"
No Description = unchecked
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
Tested successfully.
Hi,
Is this issue waiting for tests?
yes
Tested successfully.
@snehal0904 Could you mark your test result in the issue tracker? Just go to the PR here https://issues.joomla.org/tracker/joomla-cms/31357 , use the "Test this" button, select the appropriate test result and the submit. Thanks in advance.
@snehal0904 please mark your test as successfully at issue-tracker.
@snehal0904 you're right, there is no test this-button for this pr; don't know why.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-05 12:43:20 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
Thanks
Category | ⇒ | Administration com_newsfeeds Language & Strings Front End |
thanks
Strange, this PR doesn't appear in the issue tracker.