? ?
avatar uthorat
uthorat
7 Nov 2020

Steps to reproduce the issue

  1. Login to admin panel
  2. Go to Site/administrator modules
  3. Click on New module
  4. Search the module name which is not present
  5. Observe the result screen

Expected result

User should get the message that "No result found match to query"

Actual result

Blank screen displays

Additional comments

for consistency, we can use the message which is present in other search section ie " No Matching Resultsscreen shot 2020-11-07 at 11 52 28"

avatar uthorat uthorat - open - 7 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Nov 2020
avatar rajatRS
rajatRS - comment - 11 Nov 2020

Hey @uthorat I got what you are mentioning here and may I proceed to change this message :)

avatar bembelimen
bembelimen - comment - 28 Dec 2020

@rajatRS any progress so far? If you want, feel free to add it.

avatar chmst chmst - change - 17 Jan 2021
Labels Added: ?
avatar chmst chmst - labeled - 17 Jan 2021
avatar himanshu007-creator
himanshu007-creator - comment - 21 Feb 2021

Steps to reproduce the issue

  1. Login to admin panel
  2. Go to Site/administrator modules
  3. Click on New module
  4. Search the module name which is not present
  5. Observe the result screen

Expected result

User should get the message that "No result found match to query"

Actual result

Blank screen displays

Additional comments

for consistency, we can use the message which is present in other search section ie " No Matching Resultsscreen shot 2020-11-07 at 11 52 28"

Hi @uthorat , I tried to replicate the same by following the instructions. IT WORKS FINE WITHOUT DISPLAYIMG ANY BLANK SCREEN

2021-02-21 (3)

avatar brianteeman
brianteeman - comment - 21 Feb 2021

You missed step 3

avatar himanshu007-creator
himanshu007-creator - comment - 21 Feb 2021

You missed step 3

yes, now i got it. I would like to work on it, can you help me locate the file that needs to be modified?

avatar brianteeman
brianteeman - comment - 21 Feb 2021

If I could help you I would have fixed it ;)

avatar joomdonation
joomdonation - comment - 21 Feb 2021

@himanshu007-creator I think you would have to work on two files:

  • administrator/components/com_modules/tmpl/select/default.php : To add the text which will be displayed when no module found
  • And media/com_modules/js/admin-module-search.js , display the text above when no module found and hide it if there are modules returned.
avatar himanshu007-creator
himanshu007-creator - comment - 24 Feb 2021

2021-02-24

@joomdonation Sir , i was able to add the text which will be displayed when no module is found.
But i am unable to fix the javascript part.
My approach:-

  • Create an error message and make it hidden
  • use javascript to test the condition , module found or not
  • toggle the visibility of this error message depending on it
avatar richard67 richard67 - close - 13 Mar 2021
avatar richard67
richard67 - comment - 13 Mar 2021

Closing as having a pull request. It has already 2 good tests and so it RTC (ready to commit). See #32657 .

avatar richard67 richard67 - change - 13 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-13 10:01:44
Closed_By richard67
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment