? Pending

User tests: Successful: Unsuccessful:

avatar mangeshmane
mangeshmane
7 Nov 2020

Pull Request for Issue #29292

Summary of Changes

Removed unwanted class

Testing Instructions

Steps to reproduce the issue
Login to admin and set "highlight links" in your Accessibility Settings to yes.
Click Save.
Note that there is a red box around all three icons at top

Actual result BEFORE applying this Pull Request

83340240-903af600-a2cd-11ea-9d2a-52fcd78398ed

Expected result AFTER applying this Pull Request

83340208-50740e80-a2cd-11ea-8f9a-460450f46cc1

Documentation Changes Required

avatar mangeshmane mangeshmane - open - 7 Nov 2020
avatar mangeshmane mangeshmane - change - 7 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2020
Category Modules Administration
avatar mangeshmane mangeshmane - change - 7 Nov 2020
Title
Issue #29292 bug: Accessibility Highlight Links Inconsistent
Accessibility Highlight Links Inconsistent
avatar mangeshmane mangeshmane - edited - 7 Nov 2020
avatar mangeshmane mangeshmane - change - 7 Nov 2020
The description was changed
avatar mangeshmane mangeshmane - edited - 7 Nov 2020
avatar mangeshmane mangeshmane - edited - 7 Nov 2020
avatar mangeshmane mangeshmane - change - 7 Nov 2020
The description was changed
avatar jaisheela jaisheela - test_item - 7 Nov 2020 - Tested successfully
avatar jaisheela
jaisheela - comment - 7 Nov 2020

I have tested this item successfully on 00400b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31333.

avatar shindebalu shindebalu - test_item - 7 Nov 2020 - Tested successfully
avatar shindebalu
shindebalu - comment - 7 Nov 2020

I have tested this item successfully on 00400b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31333.

avatar mangeshmane mangeshmane - change - 7 Nov 2020
Title
Accessibility Highlight Links Inconsistent
[4.0] Accessibility Highlight Links Inconsistent
avatar mangeshmane mangeshmane - edited - 7 Nov 2020
avatar adj9
adj9 - comment - 7 Nov 2020

If I apply the PR I can't find the flag to activate. I wanted to try it even though there are 2 confirmations...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31333.

avatar manojLondhe
manojLondhe - comment - 7 Nov 2020

If I apply the PR I can't find the flag to activate. I wanted to try it even though there are 2 confirmations...

Go to admin users list, click on user you are logged in backend, edit that user to enable highlight links @adj9

avatar richard67
richard67 - comment - 8 Nov 2020

The "Private Messages" has indeed changed from a dropdown toggle to a link. I think it had been done with PR #25296 . So this PR here correctly removes that "dropdown-toggle" class, and this makes the accessibility tool mark it as a link. I've just done a test.

avatar richard67 richard67 - change - 8 Nov 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-08 11:04:06
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 8 Nov 2020
avatar richard67 richard67 - merge - 8 Nov 2020
avatar richard67
richard67 - comment - 8 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment