[#31326] - [4.0] Category ALT text
- Fixed in Code Base
- 14 Nov 2020
- Medium
- Build: 4.0-dev
- # 31326
- Diff
- brianteeman:imagecat
User tests: Successful: Unsuccessful:
Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a content category and a contact category and add an image
Testing Part 2
Please test three scenarios when adding an image for a menu item of Content Category Blog, Content Category List, Contact Category
-
Image Description (Alt Text) = Empty
No Description = unchecked -
Image Description (Alt Text) = "some description"
No Description = unchecked -
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories Language & Strings Front End com_content Layout |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.
The **loading="lazy" ** is absent. Is that due to copy/paste instructions? Can you tell us under what conditions alt appears without =""?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.
Fixed the copy/paste error
Can you tell us under what conditions alt appears without =""
Basically if it is alt="" then some browsers when you inspect instead of view source abbreviate alt="" to alt
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 13:54:06 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
thx
I have tested this item✅ successfully on 206c859
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31326.