[#31310] - [4.0] installer header
- Fixed in Code Base
- 8 Nov 2020
- Medium
- Build: 4.0-dev
- # 31310
- Diff
- N6REJ:4.0-installer-header-31304
User tests: Successful: Unsuccessful:
Pull Request for Issue #31304
Summary of Changes
sets correct flow for installer header
Testing Instructions
start fresh install ( or rename configuration.php )
examine header notice logo is missing & title is offset to the right.
apply pr
run "npm ci"
examine header again in both mobile and desktop
Notice everything looks nice.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
#31304 mentioned that the question mark was expected to be white. And if the logo is going to be almost invisible, due to low colour contrast, it may as well be missing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
colors have been changed to white. I forgot to update the images.
I think it still needs some work! It is coming out different on each of my browser compatibility modes (Firefox and Google Chrome on Mac). Blue on some, white on others. Too big on narrow screens. Question mark is blue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
looks like you didn't run npm ci
I have tested this item
Seems I neglected to run npm in my previous comment. It does now look fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
My screenshot with patch applied and npm run, 380px wide viewport:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
I have tested this item
Tested the header with a new build. Looks good.
Desktop
Mobile
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-08 09:08:55 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
#31304 mentioned that the question mark was expected to be white. And if the logo is going to be almost invisible, due to low colour contrast, it may as well be missing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31310.