? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
3 Nov 2020

Summary of Changes

Fixes undefined variable notice.

Testing Instructions

Go to some component's configuration.
Click Cancel button.
Check PHP error log.

Actual result BEFORE applying this Pull Request

Notice: Undefined variable: option in administrator\components\com_config\src\Controller\ComponentController.php on line 200

Expected result AFTER applying this Pull Request

No notices.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 3 Nov 2020
avatar SharkyKZ SharkyKZ - change - 3 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2020
Category Administration com_config
avatar zero-24
zero-24 - comment - 3 Nov 2020

Can you please check the line:

It seems we now have the same call twice?

avatar SharkyKZ SharkyKZ - change - 3 Nov 2020
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 3 Nov 2020

Right. Fixed.

avatar toivo toivo - test_item - 4 Nov 2020 - Tested successfully
avatar toivo
toivo - comment - 4 Nov 2020

I have tested this item successfully on 8eac71f

Tested successfully in Beta6-dev of 4 November.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31307.

avatar Quy Quy - test_item - 4 Nov 2020 - Tested successfully
avatar Quy
Quy - comment - 4 Nov 2020

I have tested this item successfully on 8eac71f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31307.

avatar Quy Quy - change - 4 Nov 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31307.

avatar chmst chmst - change - 4 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-04 18:47:42
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 4 Nov 2020
avatar chmst chmst - merge - 4 Nov 2020
avatar chmst
chmst - comment - 4 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment