There are a lot of codestyle issues with that PR and also usage of JError which is deprecated.
Please update the PR to follow our coding standards and remove the (new) usage of JError.

Ah sorry, didn't catch that this one is for J! 2.5.
So JError will be fine here of course.
It would still be nice to follow our Codestyle standards, but it is not a must.

Excuse my ignorance but isnt this already handled by the menu module

@Bakual Thanks for pointing out the problems.

@brianteeman Monitoring a MySQL server itself has shown this query and some of the session queries are being run despite the settings in configuration.php. I don't know about 3.x but for 2.5 you can see it just by enabling debug in a Joomla website and looking at "Database Queries".

Before this patch, the query in this file is in every request.

I got this error.
The file marked for modification does not exist: includes/menu.php

@goyat have you tried to merge this with a branch higher than 2.5? In 3.x this is handled somewhere else. :)

Thanks for working on this. Unfortunately this did not make it into the final release of Joomla 2.5, or it was handled elsewhere, so this is being closed. If you feel this is still a valid issue in Joomla 3 please create a new issue.