?
avatar brianteeman
brianteeman
30 Oct 2020

I guess we need a similar update for drone as #31225

@HLeithner

avatar brianteeman brianteeman - open - 30 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Oct 2020
avatar richard67
richard67 - comment - 1 Nov 2020

@HLeithner As far as I could see today, this has been fixed meanwhile, and it just needs to update all 4.0 PR's to latest 4.0-dev of the CMS, right? Or am I wrong?

avatar zero-24
zero-24 - comment - 1 Nov 2020

Or trigger the builds again when i understood it correctly given that the change was on the docker image and not in our main branch.

avatar richard67
richard67 - comment - 1 Nov 2020

So this issue can be closed?

avatar HLeithner
HLeithner - comment - 1 Nov 2020

Yes I fixed it yesterday in the docker images.

avatar HLeithner HLeithner - close - 1 Nov 2020
avatar HLeithner HLeithner - change - 1 Nov 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-11-01 12:16:01
Closed_By HLeithner
avatar richard67
richard67 - comment - 1 Nov 2020

Thanks!

avatar alikon
alikon - comment - 1 Nov 2020

what this mean in regard of the already submitted pr's ?

avatar richard67
richard67 - comment - 1 Nov 2020

It just needs to restart drone, no need to update branches, if PRs are not older than a few weeks.

avatar alikon
alikon - comment - 1 Nov 2020

look at this one https://ci.joomla.org/joomla/joomla-cms/29862 as an example

avatar richard67
richard67 - comment - 1 Nov 2020

look at this one https://ci.joomla.org/joomla/joomla-cms/29862 as an example

In such a case, last drone run so long ago that results have been deleted by the cron job, it needs an update to the branch to trigger drone again. this can be a fake update, e.g. some comment or new line, which later can be rolled back, or it can be an update to the latest changes in base branch in the CMS.

Add a Comment

Login with GitHub to post a comment