NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
29 Oct 2020

Pull Request for #31262 (comment).

Summary of Changes

Corrects SCSS import order.

Testing Instructions

@infograf768

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 29 Oct 2020
avatar SharkyKZ SharkyKZ - change - 29 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2020
Category Front End Templates (site) NPM Change
avatar infograf768
infograf768 - comment - 29 Oct 2020

I suggest to add, as for atum:
@import "../../../../../../media/vendor/fontawesome-free/scss/brands"; // order of loading is important.

avatar SharkyKZ SharkyKZ - change - 29 Oct 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2020
Category Front End Templates (site) NPM Change Administration Templates (admin) NPM Change Front End Templates (site)
avatar SharkyKZ
SharkyKZ - comment - 29 Oct 2020

Added comment.

avatar infograf768 infograf768 - test_item - 29 Oct 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 29 Oct 2020

I have tested this item successfully on 0f0864a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31268.

avatar richard67 richard67 - test_item - 29 Oct 2020 - Tested successfully
avatar richard67
richard67 - comment - 29 Oct 2020

I have tested this item successfully on 0f0864a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31268.

avatar richard67 richard67 - change - 29 Oct 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 29 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31268.

avatar drmenzelit drmenzelit - change - 29 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-29 13:37:36
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 29 Oct 2020
avatar drmenzelit drmenzelit - merge - 29 Oct 2020
avatar drmenzelit
drmenzelit - comment - 29 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment