[#31250] - [4.0] Fix file and folder deletion on updates from previous Joomla 4 Beta versions
- Fixed in Code Base
- 27 Oct 2020
- Medium
- Build: 4.0-dev
- # 31250
- Diff
- richard67:4.0-dev-fix-files-and-folder-deletion-for-4-beta-x-updates
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This pull request (PR) adds file and folder deletion to script.php for those files and folder which were deleted between Joomla 4 Beta versions (including the upcoming one).
The reason why this has to be done here is that the tool for creating the lists currently only checks the difference between 4.0 and 3.10, and so (almost) everything what happened between J4 Beta 1 and now is missing.
As agreed with @wilsonge , I have separated the beta releases into different sections for the different releases.
The few things which were not missing because added with some PR have been moved to the right section.
Testing Instructions
Update any Joomla 4 Beta version (i.e. not nightly build) to the update package which has been built for this PR.
If you use "Live Update", use following custom URL: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/31250/downloads/37111/pr_list.xml.
If you can't use "Live Update" for some reason, download the update package from following link and use "Upload & Update": https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/31250/downloads/37111/Joomla_4.0.0-beta5-dev+pr.31250-Development-Update_Package.zip.
When updating from a version before Joomla 4 Beta 4, mind the additional SQL step described here: https://docs.joomla.org/J4.x:Upgrade_to_4.0_Beta_4. Despite of what the title says, this step is also necessary when updating a Beta lower than 4 to a Beta higher than 4.
Check if the files and folder which are added by this PR to script.php are present after the update.
Finally update a current 3.10-dev or latest 3.10 nightly to the update package built for this PR. Check that it still works without errors.
Actual result BEFORE applying this Pull Request
Files and folders added by this PR to script.php have not been deleted with the update from a previous J4 Beta version.
Expected result AFTER applying this Pull Request
Files and folders added by this PR to script.php have been deleted with the update from a previous J4 Beta version.
Update from a 3.10-dev works as well as before.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-27 19:39:48 |
| Closed_By | ⇒ | wilsonge |
Merging as I want to do beta 5 now. Thanks!
Thanks!
I have tested this item✅ successfully on 8fd3213
Tested successfully. Update of a beta3 to beta5 via live update.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31250.