? ? ? Pending

User tests: Successful: Unsuccessful:

avatar ceford
ceford
26 Oct 2020

Pull Request for Issue # .

Summary of Changes

This pull request adds links to two new Help screens and fixes a problem with the Help button in the Who's online module

Testing Instructions

  1. Go to the Modules: Privacy Status Check page and click the Help button in the Toolbar
  2. Go to the Modules: Sample Data page and click the Help button in the Toolbar
  3. Go to the Modules: Who's Online page and click the Help button in the Toolbar

Actual result BEFORE applying this Pull Request

  1. 404 Not Found
  2. 404 Not found
  3. Help button inactive

Expected result AFTER applying this Pull Request

All deliver working Help pages

Documentation Changes Required

None

avatar ceford ceford - open - 26 Oct 2020
avatar ceford ceford - change - 26 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2020
Category Administration Language & Strings Modules
avatar ceford ceford - change - 26 Oct 2020
Labels Added: ? ?
avatar MartijnMaandag MartijnMaandag - test_item - 26 Oct 2020 - Tested successfully
avatar MartijnMaandag
MartijnMaandag - comment - 26 Oct 2020

I have tested this item successfully on 088a9a2

Yes thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31237.

avatar particthistle particthistle - test_item - 26 Oct 2020 - Tested successfully
avatar particthistle
particthistle - comment - 26 Oct 2020

I have tested this item successfully on 088a9a2

Nice work again @ceford
Tested successfully. All three help screens now appear correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31237.

avatar particthistle
particthistle - comment - 26 Oct 2020

Watching for when retest is required after @ceford applies change suggested by @brianteeman

avatar ceford
ceford - comment - 26 Oct 2020

Unless @brianteeman, or someone else, can provide a good reason not to use %27 in place of an apostrophe in "Site_Modules:_Who%27s_Online" I propose to leave it as it is. This string is actually a 'not to be translated' url (marked as such in Crowdin). This is what the top of the Help screen looks like in Joomla 4:

image

And in Joomla 3:

image

I don't see the point of reverting to the Joomla 3 way.

avatar Quy Quy - change - 29 Oct 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31237.

avatar rdeutz rdeutz - change - 30 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-30 12:46:08
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 30 Oct 2020
avatar rdeutz rdeutz - merge - 30 Oct 2020

Add a Comment

Login with GitHub to post a comment