[#31195] - [4.0] House cleaning => remove obsolete div element in system message container
- Fixed in Code Base
- 22 Oct 2020
- Medium
- Build: 4.0-dev
- # 31195
- Diff
- hans2103:feature/house-cleaning-and-remove-obsolete-div-element-in-system-message-container
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/drone/pr Build is failing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR will remove the obsolete <div id="system-message"></div> from layout/joomla/system/message.php
This id was used in J3 plugin installer_webinstaller. It is not used in the J4 version anymore.
Therefor this element is obsolete and can be removed.
This PR will also remove the obsolete styling for this removed element.
Testing Instructions
- Joomla 4
- Find the login module in the sidebar, don't fill any fields and press the button login.
- The page refreshes on
/index.php/author-loginwith an alert
Empty password not allowed.
The HTML of this alert is:
<div id="system-message-container" aria-live="polite"><joomla-alert type="warning" dismiss="true" class="joomla-alert--show" role="alert"><button class="joomla-alert--close" aria-label="Close"><span aria-hidden="true">×</span></button><div class="alert-heading"><span class="warning"></span><span class="sr-only">Warning</span></div><div class="alert-wrapper"><div class="alert-message">Empty password not allowed.</div></div></joomla-alert></div>
Press the X to close the alert
Actual result BEFORE applying this Pull Request
You are able to close the alert.
The HTML of the closed alert is:
<div id="system-message-container" aria-live="polite"><div id="system-message"></div></div>
Expected result AFTER applying this Pull Request
You are able to close the alert.
The HTML of the closed alert is:
<div id="system-message-container" aria-live="polite"></div>
Without the obsolete div element you can properly use the css :empty trigger to remove a margin between succeeding elements. No JS needed.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Layout Front End Templates (site) |
infograf768
- 
I have tested this item
OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31195.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31195.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-22 14:02:54 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
PR joomla/cassiopeia#194 is created to fix obsolete margin in Cassiopeia