[#31180] - Set alt-text for the feed-image if no other text is displayed (a11y)
- Closed
- 12 Mar 2021
- Medium
- Build: staging
- # 31180
- Diff
- chmst:feed-image-alt-text
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 2 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
As title says
Testing Instructions
Make a module syndication feeds.
Try different variants:
- Display text yes, and enter a text
- Display text yes, but let the text empty
- Display text no
Inspect the code for the image and see which alt text is displayed.
Actual result BEFORE applying this Pull Request
The image always has a hard coded alt-text.
Expected result AFTER applying this Pull Request
If the feed image is displayed with a text, then it has alt="",
otherwise it has a translated text "feed entries"
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
I have tested this item
done
Nominal pose modul: top-a
HTML inspect:
-
with lable = n
-
with confirmed lable but = ""
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31180.
@adj9 you have made yor test on J4 :)
It works on both versions, but the JText_:: (in 3.9) and TEXT::_ are different
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31180.
I have tested this item
The test for empty text is not correct.
To replicate the error first create a module with display text set to yes and a value in feed entries
Save and check it - all good
Now change the module to display text no - save and check
Now we do not get an alt text because there is a value for $text saved in the module
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31180.
| Labels |
Added:
?
|
||
Thank you for remembering me. Fixed now. Could you please re-test?
Fixed in J4, no need to change something in J3.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-12 10:26:28 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item✅ successfully on dfcd22f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31180.