[#31175] - Set alt="" for images in the random image module
- Fixed in Code Base
- 22 Oct 2020
- Medium
- Build: 4.0-dev
- # 31175
- Diff
- chmst:ramdom-images-alt
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Random images have their filenames as alt-text.
This is wrong for accessibility.
Testing Instructions
Make a module with random images.
In the output, inspect the source code.
Actual result BEFORE applying this Pull Request
The image has an alt-text which contains the filename of the image
Expected result AFTER applying this Pull Request
The image has alt=""
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Is it not time to retire this module. There are existing modules that can be used to present images in a truly accessible (and seo friendly) way. It had been hoped that the new media manager would have a database part where metadata could be stored with the images but that never happened sadly and alt="" doesnt solve any accessibility issues it just hides them under a blanket
@brianteeman we discussed this internally and we jumped into the conclusion that this module is just decorative. That is why we thought the alt="" way would be a good option.
To be honest we also considered removing the module for good and the media manager metadata thing and even a full revamp of the module. But I want to discuss these other options with the PD in any case as they involve much more "strategy and vision "
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31175.
RTC
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31175.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-22 07:43:28 |
| Closed_By | ⇒ | richard67 |
Thanks!
I have tested this item✅ successfully on 5056c58
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31175.