I have tested this item ✅ successfully on 3b79193

Code review: The PR adds the right type attribute to the button. See https://www.w3schools.com/tags/att_button_type.asp:

Tip: Always specify the type attribute for the element. Different browsers may use different default types for the element.

The "submit" type is the right one.

Real test: As I did not have problems with login like they were reported in issue #31165 , I could only check that login still works as well as before and that the type attribute really has been added.

I have tested this item ✅ successfully on 3b79193

I had the problems as reported in #31165 but not always, and cannot say when it occurred. So I can confirm that this is the right attribute and the problem does not occur with this change.

This should not be required as any button inside a form has the default value of "type=submit"

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

This should not be required as any button inside a form has the default value of "type=submit"

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

@brianteeman But does it do harm to specify the type attribute?

No - but my point is that if everyone is saying this is an "intermittent" problem then I doubt very much that adding the default value for the button is actually resolving the problem

No - but my point is that if everyone is saying this is an "intermittent" problem then I doubt very much that adding the default value for the button is actually resolving the problem

Agree.

RTC

tks