Feeling Lucky
?
?
?
[#31150] - Rename method arguments to use camelCase casing (module directories)
- Fixed in Code Base
- 27 Oct 2020
- Medium
- Build: staging
- # 31150
- Diff
- SharkyKZ:j3/php8/camelcase-args-modules
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #30988.
Summary of Changes
Renames some method arguments to use camelCase casing.
Testing Instructions
Thorough code review / Joomla works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 19 Oct 2020
Calling a method with more arguments than it accepts does not cause issues.
Quy
- comment
- 23 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31150.
alikon
- comment
- 24 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31150.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 24 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31150.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-27 13:20:58 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
@SharkyKZ i'm not sure whether we can remove that argument from a public method?