User tests: Successful: Unsuccessful:
Pull Request for Issue #27975
Attempting to create working mobile view.
go to administrator/index.php?option=com_media&path=local-0:/
check desktop & mobile view.
apply pr
run npm run build:com_media
recheck desktop & mobile views in both portrait & landscape.
Known issues:
Currently sidebar doesn't resize as you drill down deeper in desktop view
breadcrumb always present.
breadcrumbs don't wrap properly
info flyout too narrow in mobile view
On some mobile screen file path doesn't wrap.
zoom in/out doesn't work properly. ( sometimes + = out )
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
Can you explain what you mean by this please
Currently sidebar doesn't resize as you drill down deeper
Try to move media-breadcrumbs onto a second row for mobile views and probably get rid of the search on mobile views as well
hiding the search input field on mobile view and replace it with a floating search-icon instead would be a good idea.
hiding the search input field on mobile view and replace it with a floating search-icon instead would be a good idea.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31140.
idk how to replace it.. hiding it is easy part
Try to move media-breadcrumbs onto a second row for mobile views and probably get rid of the search on mobile views as well
do we even need/wants breadcrumbs on desktop?
Can someone check RTL for breadcrumb.scss. Made several changes in that file.
idk how to fix the wordwrap for file path since it would have to break on / and it seems to be device specific.
lastly, zoom in/out is not something "I" can fix, so that will have to be for someone else in another pr or supply the code here.
All in all I"m going to say this is as complete as can be for this pr.
READY FOR TESTING
Title |
|
@richard67 I don't understand what drone is trying to say. Perhaps class in tester needs to change?
@richard67 yep, test is going to need to be modified in some way. The only time breadcrumbs display now is in mobile view.
/**
* Test that it's possible to navigate to a subfolder using breadcrumb.
*
* @param Media $I
*
* @since 4.0.0
*
* @throws Exception
*/
public function navigateUsingBreadcrumb(Media $I)
{
$I->wantToTest('that it is possible to navigate to a subfolder using breadcrumb.');
$I->amOnPage(MediaListPage::$url . 'banners');
$I->waitForMediaLoaded();
$I->clickOnLinkInBreadcrumb('images');
$I->waitForMediaLoaded();
$I->seeInCurrentUrl(MediaListPage::$url);
$I->seeContents($this->contents['root']);
}
Category | Administration com_media NPM Change | ⇒ | Administration com_media NPM Change Unit Tests |
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
?
Removed: ? |
Labels |
Added:
?
?
Removed: ? ? |
Labels |
Added:
Conflicting Files
?
?
Removed: ? ? |
Labels |
Added:
?
?
?
Removed: Conflicting Files ? ? |
Labels |
Added:
?
?
?
Removed: ? ? ? |
Labels |
Added:
?
?
?
Removed: ? ? ? |
Are there updates still outstanding or is that label resolved and should be removed?
Also, there are 2 outstanding items so I assume it is not ready for testing.
Labels |
Added:
?
?
?
Removed: ? ? ? |
Labels |
Added:
?
?
?
Removed: ? ? ? |
Also, there are 2 outstanding items so I assume it is not ready for testing.
I don't see 2, am I missing something?
Under known issues, are these to be fixed in this PR?
On some mobile screen file path doesn't wrap.
zoom in/out doesn't work properly. ( sometimes + = out )
Labels |
Added:
?
?
?
Removed: ? ? ? |
Problems I see today (2020-11-18):
On 1440 px wide screen: Magnify buttons give wrong sequences; I button opens slider to cover about 75% of div width including image icons.
On simulated mobile: improving but still needs work. Keep going!
Labels |
Added:
?
?
?
Removed: ? ? ? |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-14 20:42:04 |
Closed_By | ⇒ | N6REJ | |
Labels |
Added:
?
?
Conflicting Files
?
?
?
Removed: ? ? ? ? |
Hi, before patch:
after patch: