? ? Conflicting Files ? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
17 Oct 2020

Pull Request for Issue #27975

Summary of Changes

Attempting to create working mobile view.

Testing Instructions

go to administrator/index.php?option=com_media&path=local-0:/
check desktop & mobile view.
apply pr
run npm run build:com_media
recheck desktop & mobile views in both portrait & landscape.

Known issues:

  • Currently sidebar doesn't resize as you drill down deeper in desktop view

  • breadcrumb always present.

  • breadcrumbs don't wrap properly

  • info flyout too narrow in mobile view

  • On some mobile screen file path doesn't wrap.

  • zoom in/out doesn't work properly. ( sometimes + = out )

Actual result BEFORE applying this Pull Request

note8

Expected result AFTER applying this Pull Request

image
note8
image

Documentation Changes Required

avatar N6REJ N6REJ - open - 17 Oct 2020
avatar N6REJ N6REJ - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Administration com_media NPM Change
avatar N6REJ N6REJ - change - 17 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 17 Oct 2020
avatar PhocaCz
PhocaCz - comment - 17 Oct 2020

Hi, before patch:
img

after patch:
img

avatar N6REJ
N6REJ - comment - 18 Oct 2020

@PhocaCz this was NOT on a mobile device right? It was simulated?

avatar N6REJ N6REJ - change - 18 Oct 2020
Labels Added: NPM Resource Changed ?
avatar N6REJ N6REJ - change - 18 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 18 Oct 2020
avatar N6REJ
N6REJ - comment - 18 Oct 2020

Got it to here so far
note8

avatar N6REJ N6REJ - change - 18 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 18 Oct 2020
avatar N6REJ N6REJ - change - 18 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 18 Oct 2020
avatar brianteeman
brianteeman - comment - 18 Oct 2020

Can you explain what you mean by this please

Currently sidebar doesn't resize as you drill down deeper

avatar PhocaCz
PhocaCz - comment - 18 Oct 2020

@PhocaCz this was NOT on a mobile device right? It was simulated?

Yes, simulated

avatar brianteeman
brianteeman - comment - 18 Oct 2020

Try to move media-breadcrumbs onto a second row for mobile views and probably get rid of the search on mobile views as well

avatar jiweigert
jiweigert - comment - 19 Oct 2020

hiding the search input field on mobile view and replace it with a floating search-icon instead would be a good idea.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31140.
avatar N6REJ
N6REJ - comment - 19 Oct 2020

hiding the search input field on mobile view and replace it with a floating search-icon instead would be a good idea.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31140.

idk how to replace it.. hiding it is easy part

avatar N6REJ
N6REJ - comment - 19 Oct 2020

Try to move media-breadcrumbs onto a second row for mobile views and probably get rid of the search on mobile views as well

do we even need/wants breadcrumbs on desktop?

avatar N6REJ
N6REJ - comment - 19 Oct 2020

as of 110e506
Screen Shot 2020-10-19 at 17 51 50
image

avatar N6REJ N6REJ - change - 19 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 19 Oct 2020
avatar N6REJ
N6REJ - comment - 19 Oct 2020

based on feedback search removed on < md
image

avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ
N6REJ - comment - 20 Oct 2020

paused here for the night
image

avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ N6REJ - change - 20 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 20 Oct 2020
avatar N6REJ
N6REJ - comment - 20 Oct 2020

Can someone check RTL for breadcrumb.scss. Made several changes in that file.
idk how to fix the wordwrap for file path since it would have to break on / and it seems to be device specific.
lastly, zoom in/out is not something "I" can fix, so that will have to be for someone else in another pr or supply the code here.
All in all I"m going to say this is as complete as can be for this pr.
READY FOR TESTING

avatar N6REJ N6REJ - change - 20 Oct 2020
Title
[4.0][DRAFT] Make mediamanager usable on mobile
[4.0] Make mediamanager usable on mobile
avatar N6REJ N6REJ - edited - 20 Oct 2020
a57f090 20 Oct 2020 avatar N6REJ scss
0652c71 20 Oct 2020 avatar N6REJ scss
0d17b68 20 Oct 2020 avatar N6REJ scss
79af9e2 20 Oct 2020 avatar N6REJ scss
avatar N6REJ
N6REJ - comment - 20 Oct 2020

@richard67 I don't understand what drone is trying to say. Perhaps class in tester needs to change?

avatar richard67
richard67 - comment - 21 Oct 2020

@N6REJ I think I had explained you how to find the drone logs.

The system test fails here at a step labelled "Test that it is possible to navigate to a subfolder using breadcrumb.".

So I guess that is related to your changes for the breadcrumbs.

avatar N6REJ
N6REJ - comment - 21 Oct 2020

@richard67 yep, test is going to need to be modified in some way. The only time breadcrumbs display now is in mobile view.

	/**
	 * Test that it's possible to navigate to a subfolder using breadcrumb.
	 *
	 * @param   Media  $I
	 *
	 * @since   4.0.0
	 *
	 * @throws Exception
	 */
	public function navigateUsingBreadcrumb(Media $I)
	{
		$I->wantToTest('that it is possible to navigate to a subfolder using breadcrumb.');
		$I->amOnPage(MediaListPage::$url . 'banners');
		$I->waitForMediaLoaded();
		$I->clickOnLinkInBreadcrumb('images');
		$I->waitForMediaLoaded();
		$I->seeInCurrentUrl(MediaListPage::$url);
		$I->seeContents($this->contents['root']);
	}
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2020
Category Administration com_media NPM Change Administration com_media NPM Change Unit Tests
avatar N6REJ N6REJ - change - 21 Oct 2020
Labels Added: ?
avatar N6REJ N6REJ - change - 21 Oct 2020
Labels Added: ?
Removed: ?
avatar N6REJ N6REJ - change - 21 Oct 2020
Labels Added: ?
Removed: ?
avatar N6REJ N6REJ - change - 21 Oct 2020
Labels Added: ?
Removed: ?
avatar N6REJ N6REJ - change - 21 Oct 2020
Labels Added: ?
Removed: ?
avatar N6REJ N6REJ - change - 24 Oct 2020
Labels Added: ? ?
Removed: ?
avatar N6REJ N6REJ - change - 24 Oct 2020
Labels Added: ? ?
Removed: ? ?
avatar N6REJ N6REJ - change - 29 Oct 2020
Labels Added: Conflicting Files ? ?
Removed: ? ?
avatar N6REJ N6REJ - change - 31 Oct 2020
Labels Added: ? ? ?
Removed: Conflicting Files ? ?
avatar N6REJ N6REJ - change - 1 Nov 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar N6REJ N6REJ - change - 8 Nov 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar N6REJ N6REJ - change - 10 Nov 2020
The description was changed
avatar N6REJ N6REJ - edited - 10 Nov 2020
avatar brianteeman
brianteeman - comment - 11 Nov 2020

Are there updates still outstanding or is that label resolved and should be removed?

avatar richard67
richard67 - comment - 11 Nov 2020

Last changes after @Quy has added the "Updates Requested" label were only clean branch updates, so I am not sure.

@Quy Could you check and report back? Thanks in advance.

avatar Quy
Quy - comment - 11 Nov 2020

Also, there are 2 outstanding items so I assume it is not ready for testing.

avatar N6REJ N6REJ - change - 11 Nov 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar N6REJ N6REJ - change - 11 Nov 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar N6REJ
N6REJ - comment - 11 Nov 2020

Also, there are 2 outstanding items so I assume it is not ready for testing.

I don't see 2, am I missing something?

avatar Quy
Quy - comment - 11 Nov 2020

Under known issues, are these to be fixed in this PR?

On some mobile screen file path doesn't wrap.

zoom in/out doesn't work properly. ( sometimes + = out )

avatar N6REJ
N6REJ - comment - 11 Nov 2020

@Quy no. I honestly don't know vue even remotely enough to tackle them. I wish I did.
I've tackled the path as best as I know how. it's only in the info window
image

avatar N6REJ N6REJ - change - 14 Nov 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar ceford
ceford - comment - 18 Nov 2020

Problems I see today (2020-11-18):
On 1440 px wide screen: Magnify buttons give wrong sequences; I button opens slider to cover about 75% of div width including image icons.
On simulated mobile: improving but still needs work. Keep going!
screen shot 2020-11-18 at 19 05 06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31140.
avatar N6REJ N6REJ - change - 1 Dec 2020
Labels Added: ? ? ?
Removed: ? ? ?
avatar N6REJ N6REJ - change - 14 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-14 20:42:04
Closed_By N6REJ
Labels Added: ? ? Conflicting Files ? ? ?
Removed: ? ? ? ?
avatar N6REJ N6REJ - close - 14 Jan 2022

Add a Comment

Login with GitHub to post a comment