[#31137] - [4.0] Use component when building session key
- Fixed in Code Base
- 1 Nov 2020
- Medium
- Build: 4.0-dev
- # 31137
- Diff
- SharkyKZ:j4/fix/component-config-context
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Summary of Changes
Missed this in #31105. Adds component to the session key to ensure unique key for each component.
Testing Instructions
Testing requires up to date version with #31105 already applied.
Enable some Captcha plugins.
Go to Users configuration.
In Captcha field select some captcha plugin.
In Password Options tab set Minimum Characters to a value lower than 8.
Click Save. Ignore
Navigate away but don't use Close button in the toolbar.
Go to Articles configuration.
Inspect Captcha field.
Actual result BEFORE applying this Pull Request
Captcha field contains whatever was selected in Users configuration.
Expected result AFTER applying this Pull Request
Captcha field has default value.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
I have tested this item
Patch resolves issue successfully.
On making the changes outlined in the testing instructions, before test captcha setting transferred across to articles settings.
After patch applied, default value is retained in the articles settings.
Raises another issue though: If you manually type in a value <8 on the password length option, it doesn't validate it and show a message to indicate why it can't be a value less than 8 characters.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.
I have tested this item
Patch resolves issue successfully.
On making the changes outlined in the testing instructions, before test captcha setting transferred across to articles settings.
After patch applied, default value is retained in the articles settings.
Raises another issue though: If you manually type in a value <8 on the password length option, it doesn't validate it and show a message to indicate why it can't be a value less than 8 characters.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-01 08:34:44 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merged thanks
I don't know how to reproduce this,
Undefined variable: option in \administrator\components\com_config\src\Controller\ComponentController.php on line 200
I have tested this item✅ successfully on 7ab3736
Hint for test:
Usersconfiguration.Users>Options.Articlesconfiguration.Articles>Options.Captchafield.Editing Layout, inspect fieldAllow Captcha on submit.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.