? ?

Success

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
17 Oct 2020

Summary of Changes

Missed this in #31105. Adds component to the session key to ensure unique key for each component.

Testing Instructions

Testing requires up to date version with #31105 already applied.

Enable some Captcha plugins.
Go to Users configuration.
In Captcha field select some captcha plugin.
In Password Options tab set Minimum Characters to a value lower than 8.
Click Save. Ignore
Navigate away but don't use Close button in the toolbar.
Go to Articles configuration.
Inspect Captcha field.

Actual result BEFORE applying this Pull Request

Captcha field contains whatever was selected in Users configuration.

Expected result AFTER applying this Pull Request

Captcha field has default value.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 17 Oct 2020
avatar SharkyKZ SharkyKZ - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Administration com_config
avatar gostn gostn - test_item - 30 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 30 Oct 2020

I have tested this item successfully on 7ab3736

Hint for test:

Testing Instruction what it mean
Go to Users configuration. Open Users > Options.
Go to Articles configuration. Open Articles > Options.
Inspect Captcha field. Open tab Editing Layout, inspect field Allow Captcha on submit.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.
avatar particthistle particthistle - test_item - 1 Nov 2020 - Tested successfully
avatar particthistle
particthistle - comment - 1 Nov 2020

I have tested this item successfully on 7ab3736

Patch resolves issue successfully.

On making the changes outlined in the testing instructions, before test captcha setting transferred across to articles settings.

After patch applied, default value is retained in the articles settings.

Raises another issue though: If you manually type in a value <8 on the password length option, it doesn't validate it and show a message to indicate why it can't be a value less than 8 characters.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.

avatar particthistle
particthistle - comment - 1 Nov 2020

I have tested this item successfully on 7ab3736

Patch resolves issue successfully.

On making the changes outlined in the testing instructions, before test captcha setting transferred across to articles settings.

After patch applied, default value is retained in the articles settings.

Raises another issue though: If you manually type in a value <8 on the password length option, it doesn't validate it and show a message to indicate why it can't be a value less than 8 characters.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.

avatar alikon alikon - change - 1 Nov 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31137.

avatar zero-24 zero-24 - change - 1 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-01 08:34:44
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 1 Nov 2020
avatar zero-24 zero-24 - merge - 1 Nov 2020
avatar zero-24
zero-24 - comment - 1 Nov 2020

Merged thanks 👍

avatar Quy
Quy - comment - 3 Nov 2020

I don't know how to reproduce this,

Undefined variable: option in \administrator\components\com_config\src\Controller\ComponentController.php on line 200

avatar SharkyKZ
SharkyKZ - comment - 3 Nov 2020

@Quy please test #31307.

Add a Comment

Login with GitHub to post a comment