? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
17 Oct 2020

Pull Request for Issue #31130 .

Summary of Changes

delete banner from api even if it is published status like article

Testing Instructions

create a banner and publish it

DELETE api/index.php/v1/banners/{id}

Actual result BEFORE applying this Pull Request

error

Expected result AFTER applying this Pull Request

you can delete it even if it is in status published

Documentation Changes Required

?

avatar alikon alikon - open - 17 Oct 2020
avatar alikon alikon - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Administration com_banners
8ff498e 17 Oct 2020 avatar alikon oops
avatar alikon alikon - change - 17 Oct 2020
Labels Added: ?
avatar Razzo1987 Razzo1987 - test_item - 17 Oct 2020 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

I have tested this item successfully on 8ff498e

Perfect.

If the chose of directly delete the item from API we need to fix all others API


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31134.

avatar flo-the-cat flo-the-cat - test_item - 17 Oct 2020 - Tested successfully
avatar flo-the-cat
flo-the-cat - comment - 17 Oct 2020

I have tested this item successfully on 8ff498e

Works as it should


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31134.

avatar richard67 richard67 - change - 17 Oct 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31134.

avatar HLeithner
HLeithner - comment - 18 Oct 2020

not sure if this is the way to go (not only if direct delete should be allowed see #31130) also if the implementation is the best way.

avatar alikon
alikon - comment - 19 Oct 2020

that's 1 of the reasons i've not closed #31130....
but at some point in time ie before RC some decisions should be taken

avatar rdeutz rdeutz - change - 27 Oct 2020
Status Ready to Commit Discussion
avatar rdeutz
rdeutz - comment - 27 Oct 2020

removing RTC because a final decision isn't made #31130 (comment)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31134.

avatar gostn
gostn - comment - 27 Nov 2020

a ´final decision´ isn't made since one month.

avatar alikon
alikon - comment - 4 Dec 2020

closing as per #31130 (comment)

avatar alikon alikon - close - 4 Dec 2020
avatar alikon alikon - change - 4 Dec 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-12-04 15:52:19
Closed_By alikon
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment