User tests: Successful: Unsuccessful:
There is no issue number associated with these changes
This is my attempt to contribute to the project by improving the coding standard as a Joomla non-expert.
I don't honestly care how much of my stuff gets included into the core, but I just want to give my 2 cents and hope that decision makers will offer constructive feedback so that I can improve my contributions.
I have done a full-file review of just two randomly selected files. The intention is to make no behavioural changes. The changes are based on a range of benefits, such as:
none
none
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Front End Plugins |
@mickmackusa please create a PR of the bump.php changes against staging, I will look at it then.
As george already said don't do array conversation in j4 if not needed because it makes j3->j4 merges harder.
About the Switch to if conversion you can do this but I think with have 100 of these constructs. I don't see a good reason to waste time on this because we have much more important code to fix.
I'm closing this PR and hope you create a new one at least for bump.php at staging branch.
Thanks for you engagement.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 11:21:03 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
this should be done for 4,1 as its too late in the release cycle for 4.0 (my personal opinion only)