? Pending

User tests: Successful: Unsuccessful:

avatar sakiss
sakiss
15 Oct 2020

Pull Request for Issue # .

Summary of Changes

Currently the item's limit for the Finder's result is being read from the Joomla global config.
This allows to set a pagination limit for the Finder's results, in the respective menu item.

Testing Instructions

Apply the patch, go to the menu item for the finder's results > Advanced > Select number of items per page
There set the number of items you want.

Actual result BEFORE applying this Pull Request

Getting the items per page from the Joomla global configuration.

Expected result AFTER applying this Pull Request

Getting the items per page from the finder's menu item's configuration.

Documentation Changes Required

DNK

avatar sakiss sakiss - open - 15 Oct 2020
avatar sakiss sakiss - change - 15 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2020
Category Front End com_finder
avatar sakiss sakiss - change - 15 Oct 2020
The description was changed
avatar sakiss sakiss - edited - 15 Oct 2020
avatar sakiss sakiss - change - 15 Oct 2020
The description was changed
avatar sakiss sakiss - edited - 15 Oct 2020
avatar sakiss sakiss - change - 15 Oct 2020
Title
Finder pagination
[4.0] Finder pagination
avatar sakiss sakiss - edited - 15 Oct 2020
avatar sakiss sakiss - change - 15 Oct 2020
Labels Added: ?
avatar chmst
chmst - comment - 15 Oct 2020

This could be done for every list layout.
But it is a new feature.
Documentation has to be changed if this is implemented.

avatar jiweigert
jiweigert - comment - 15 Oct 2020

Documentation change indeed,
but for the default value, I would recommend to get that value from prior source in the global configuration.
If someone have changed that value, it would be surprising when the number of results per page would change.

Maybe you could change this too Finder setting -> Global Setting -> Hardcoded value?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31099.
avatar HLeithner
HLeithner - comment - 15 Oct 2020

@sakiss can you please merge the current 4.0-dev branch into your PR

avatar richard67
richard67 - comment - 15 Oct 2020

@sakiss can you please merge the current 4.0-dev branch into your PR

To be more precise: The 4.0-dev branch of the CMS repository, not of your fork. It seems your 4.0-dev branch was very outdated when you have created this PR and the other one, #31100 based on it, because both PRs fail in our automated test due to outdated testing configuration from before February.

avatar sakiss
sakiss - comment - 16 Oct 2020

@HLeithner @richard67 Thank you guys!
I accidentally pulled from my origin repo instead of the upstream.

Though after pulling from the upstream, i am facing an exception "There is no "field.passwordview" asset of a "script" type in the registry." Run both composer install and npm install without any result.
Any help is welcome!

avatar richard67
richard67 - comment - 16 Oct 2020

@sakiss Maybe not pull but merge changes from upstream/4.0-dev into origin/finder_pagination, assuming the remote for your GitHub repository (CMS fork) is "origin" and the remote for the CMS repository is "upstream".

You can check that by entering "git remote -vv" in a git client's command shell.

If the result looks as follows, it is like I assumed above:

origin  https://github.com/sakiss/joomla-cms.git (fetch)
origin  https://github.com/sakiss/joomla-cms.git (push)
upstream        https://github.com/joomla/joomla-cms.git (fetch)
upstream        https://github.com/joomla/joomla-cms.git (push)

A good way to always keep your base branches (staging, 4.0-dev, 4.1-dev) for making PRs up to date with the same branches of the CMS is e.g. for the 4.0-dev branch following sequence of commands in a git client's command shell:

git checkout 4.0-dev
git remote update
git clean -d -x -f
git reset --hard upstream/4.0-dev
push origin +4.0-dev

After this, the 4.0-dev branch of your GitHub repository will be identical with the 4.0-dev of the cms, and all local untracked files and folder, e.g. remainders of a previous Joomla installation using that git clone will be removed locally.

If then making a PR for 4.0, just make the branch for that PR based on your (previously updated as described above) 4.0-dev branch, and all will be fine.

For now I would suggest to try with merging as I wrote at the top.

avatar sakiss
sakiss - comment - 16 Oct 2020

@richard67 Thank you!

My problem is that my Joomla is broken after pulling/merging from the upstream. npm install command seems like it did not complete and exited with me an error.
exception

avatar richard67
richard67 - comment - 16 Oct 2020

As I've said first, you shall not pull but you shall merge into this branch.

avatar richard67
richard67 - comment - 16 Oct 2020

Current 4.0-dev branch of the CMS works fine here, no such issue.

avatar VladimirAus VladimirAus - test_item - 17 Oct 2020 - Tested successfully
avatar VladimirAus
VladimirAus - comment - 17 Oct 2020

I have tested this item successfully on 97bdb0c

Worked.
Dropdown for number of items appeared on the advanced menu tab after applying the patch.
Search results reflected the change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31099.

avatar ThomasFinnern ThomasFinnern - test_item - 17 Oct 2020 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 17 Oct 2020

I have tested this item successfully on 97bdb0c

Before 20 items, after 30 items found as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31099.

avatar ThomasFinnern
ThomasFinnern - comment - 17 Oct 2020

before 20 items after 30 items as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31099.

avatar richard67
richard67 - comment - 17 Oct 2020

@sakiss If you want, remove the draft status by using the "Ready for review" button. The PR has 2 good tests now and so could get RTC (ready to commit), but only if it is not draft anymore.

@HLeithner As you know about the issue with failing tests due to old branch: Would that keep us from merging it? I think no, but as usual I'm not 100% sure.

avatar HLeithner
HLeithner - comment - 17 Oct 2020

@richard67 I merged current 4.0-dev branched into the pr (only 1833 commits behind^^) drone should work now.

avatar richard67
richard67 - comment - 17 Oct 2020

@HLeithner Appveyor shows it is not able to build non-mergeable pull request.

avatar HLeithner HLeithner - change - 17 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-17 20:26:52
Closed_By HLeithner
avatar HLeithner HLeithner - close - 17 Oct 2020
avatar HLeithner HLeithner - merge - 17 Oct 2020
avatar HLeithner
HLeithner - comment - 17 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment