Feeling Lucky
?
?
[#31080] - [4.0] Move calls out of the loop
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31080
- Diff
- SharkyKZ:j4/micro/image-pathinfo
User tests: Successful: Unsuccessful:
Summary of Changes
Minor optimization, combines and moves pathinfo() calls out of the loop.
Testing Instructions
Test that multiple thumbnail files are created correctly. E.g. use this code:
$image = new Joomla\CMS\Image\Image(JPATH_ROOT . '/images/powered_by.png');
$image->createThumbs(['294x44', '147x22', '74x11']);
And check that 3 thumbnails are created in images/thumbs directory.
Expected result AFTER applying this Pull Request
Works like before
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
ceford
- comment
- 14 Oct 2020
I have tested this item
I found a convenient place to put the test code was in administrator/components/com_banners/tmpl/banners/default.php - images created with and without the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31080.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 14 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31080.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 14:04:16 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
richard67
- comment
- 15 Oct 2020
Thanks!
I have tested this item✅ successfully on 8b12434
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31080.