Feeling Lucky
?
[#3107] - Let users define TinyMCE valid elements (insted of extended valid elements that has no effect)
- Closed
- 2 Jan 2015
- Medium
- Build: staging
- # 3107
- Diff
- s2software:master
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
For exemple, if I need to prevent empty tag strip, have to define "[]" in TinyMCE valid_elements option. If I define "[]" in extended_valid_elements (like Joomla current code), it doesn't work.
s2software
- comment
- 15 Feb 2014
Hi wilsonge. I see... You're right. So I cancel this PR and I open a new one with the new "Valid Elements" parameter added. Can I do that?
wilsonge
- comment
- 16 Feb 2014
Yes absolutely. You just can just edit your branch as you need to :)
nicksavov
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | External Library |
brianteeman
- comment
- 2 Jan 2015
Closing this for the reasons stated above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3107.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-02 21:44:11 |
| Closed_By | ⇒ | brianteeman |
| Closed_Date | 2015-01-02 21:44:11 | ⇒ | 2015-01-02 21:44:12 |
I don't think we can do this for b/c reasons. People will suddenly find that elements previously valid won't be valid (extended_valid_elements extends the default valid elements)
Secondly if you are proposing this in your PR then we should remove the extended_valid_options - you can't have them both coming from the same parameter!!