? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
11 Oct 2020

Summary of Changes

More Switch statement fixes - fixes missing breaks in switch statements

Testing Instructions

Code review

avatar PhilETaylor PhilETaylor - change - 11 Oct 2020
Status New Pending
avatar PhilETaylor PhilETaylor - open - 11 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Category Administration com_config com_users Libraries
avatar ChristineWk ChristineWk - test_item - 12 Oct 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 12 Oct 2020

I have tested this item successfully on 5fe94dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31065.

avatar richard67
richard67 - comment - 12 Oct 2020

@ChristineWk How have you tested this? Just code review? Did you notice my review comment above? I think this change will break at least one of the datetime range filters for users (register date or last visit date) in frontend.

avatar PhilETaylor
PhilETaylor - comment - 12 Oct 2020

I saw your comment but have not had time to circle back and check in-depth yet. Closing until I do.

avatar PhilETaylor PhilETaylor - change - 12 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-12 11:14:37
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 12 Oct 2020
avatar ChristineWk
ChristineWk - comment - 12 Oct 2020

@richard67
Yes, just Code Review. When I checked issues.joomla .....you can't see comment. Sorry I hv tested ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31065.

Add a Comment

Login with GitHub to post a comment