Feeling Lucky
?
[#31051] - [4] Return is unnecessary as the last statement in a void method
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31051
- Diff
- PhilETaylor:returnnotneeded
- Pending continuous-integration/drone/pr Build is running Details
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
User tests: Successful: Unsuccessful:
Summary of Changes
Return is unnecessary as the last statement in a void method
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
PhilETaylor
- comment
- 11 Oct 2020
You don't need to return early within a if/elseif/elseif/else block if no code follow the block, as PHP will simply be returning without further processing in that method anyway.
These are all "Code Smell" as reported by phpStorm.
ceford
- comment
- 14 Oct 2020
I have tested this item
Saw the code changes - seem OK. But in plugins/system/redirect/redirect.php the removed return is not the last statement in the method. It is the last statement in an if/elseif block.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31051.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 21:55:15 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 15 Oct 2020
LGTM. Thanks!
In the catch blocks in plugins/system/redirect/redirect.php are 2 returns missing. Don't know if they are mean as "early return" at least they are unneeded.