[#31048] - [4.0] Add WebP support to Image library
- Fixed in Code Base
- 16 Oct 2020
- Medium
- Build: 4.0-dev
- # 31048
- Diff
- SharkyKZ:j4/impr/image/webp
User tests: Successful: Unsuccessful:
Summary of Changes
Adds WebP support to image library.
Testing Instructions
Upload a webp image to template directory.
Go to com_templates.
In configuration add webp to Valid Image Formats field.
Go to template files and try to edit the image.
Actual result BEFORE applying this Pull Request
Error:
Attempting to load an image of unsupported type image/webp
Expected result AFTER applying this Pull Request
Image can be opened and edited (but is saved in wrong format).
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
No. All images are saved as JPEGs.
Ah, ok.
At least JPEG and not BMP ;-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.
@SharkyKZ can you check if GD supports AVIF files and if so enable them as well?
Info: https://jakearchibald.com/2020/avif-has-landed/
I don't think it does.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
|
||
Previous tests are still valid since changes after those were only in code style (indent) and comment.
For the question if GD support AVIF format.
As the underlying libgd don't support it, GD does not either.
There is an open issue at: libgd/libgd#557
Basically, they wait for a plugin that that they can link to and do the work.. or someone who implement avif support.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.
Should the installation sql/xml files be updated to include webp for Valid Image Formats?
how about adding webm @ the same time?
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-16 11:07:47 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
What are your opinions about backporting this into the 3.x branch?
Hey, I'm excited to see this interest in AVIF from Joomla!
I'm working on implementing libgd/libgd#557 right now...
Thanks for letting me know! I can do that.
Just letting you know that this PR is almost out of review. I expect it to be merged soon!
@SharkyKZ Is there something we can do to solve the "is saved in wrong format"? If so, you want to do it with this PR, or want to make a new one, or not want to do it at all?