[#31032] - [4.0] return to dashboard link
- Closed
- 10 Oct 2020
- Medium
- Build: 4.0-dev
- # 31032
- Diff
- brianteeman:sh3
User tests: Successful: Unsuccessful:
Pull Request for Issue #30952 .
Summary of Changes
Ensures the link on the error page works when your site is not on the standard ports
@PhilETaylor please test this - I doubt many of the regular testers will change their apache config
I am surprised you havent come across this in other places
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
Sorry this is not right.
$this->baseurl = Uri::base(true);This gives "/administrator"
$this->baseurl = Uri::base(false);This gives "http://127.0.0.1:4444/administrator/"
The true/false param is for pathonly so it makes sense that it should be false whereas your PR has true :-)
Also once using
$this->baseurl = Uri::base(false);
before the // template params line - This then makes the SVG paths with double // in the path
"http://127.0.0.1:4444/administrator//templates/atum/images/logos/brand-small.svg"
I can't reproduce the issue.
I can't reproduce the issue.
Sad to hear that.
I have just retested in all three main browsers (safari, chrome, Firefox) and I can replicate in all
Using the error page, on http with a web server on a custom port number,
http://127.0.0.1:4444/administrator/index.php?option=com_media&task=file.edit&id=0
The link is then "/administrator" which when clicked goes to http://127.0.0.1/administrator/ losing the port number
I am closing this as I see now my code made zero change and it was actually working without it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-10 12:01:54 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
and yes I also tested on an ip address and not just on localhost
@zero-24 please check the rips report