NPM Resource Changed ? ? Failure

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
9 Oct 2020

Pull Request for Issue #29733

Summary of Changes

move icon to block for webauth button

Testing Instructions

Access Joomla 4 over a SSL
Go to /administrator/
notice that icon is missing
apply pr.
in termal run npm ci
notice that icon is showing in webauth block
notice that the joomla logo is colorized

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 9 Oct 2020
avatar N6REJ N6REJ - change - 9 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2020
Category Repository NPM Change
avatar PhilETaylor
PhilETaylor - comment - 9 Oct 2020

Black on blue?... any chance it can be white? and why double the height of the button? Sorry, don't like it :) :) :)

And No, I could not do better :)

avatar N6REJ
N6REJ - comment - 9 Oct 2020

can definitely be white. Not sure why it's black. I was thinking the same thing to be honest.
as for making it smaller, believe it or not it doesn't play nice. I tried several times to get the block to a more uniform size and was unable to.
I can always go back to the drawing board if desired.

avatar N6REJ
N6REJ - comment - 9 Oct 2020

how's this?
image

avatar N6REJ N6REJ - change - 9 Oct 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2020
Category Repository NPM Change Repository NPM Change Front End Plugins
avatar PhilETaylor
PhilETaylor - comment - 9 Oct 2020

Much Better but still bad :)

Its not your fault - its just a crappy logo which then pushes the text to "appear" not centered.

Maybe less padding to the left of "Web" maybe? but what do I know :)

avatar N6REJ
N6REJ - comment - 9 Oct 2020

This is the best I can do.
image

avatar richard67
richard67 - comment - 10 Oct 2020

@N6REJ Could you fix the SCSS code style errors reported here by Drone? https://ci.joomla.org/joomla/joomla-cms/36296/1/22

They are mainly about ordering of properties. The reason why you didn't notice that might be that drone failed for unrelated reasons at some other test before running the scss cs test.

Now after I have restarted drone it turned out there are these scss code style errors.

Thanks in advance.

avatar PhilETaylor
PhilETaylor - comment - 10 Oct 2020

This is the best I can do.

Like I said I don't think this is your fault - just a crappy logo... Can we even just remove the logo? after all its never shown to anyone before you fixed it anyway :) haha that would solve all the issues. !?

avatar richard67
richard67 - comment - 10 Oct 2020

Like I said I don't think this is your fault - just a crappy logo... Can we even just remove the logo? after all its never shown to anyone before you fixed it anyway :) haha that would solve all the issues. !?

Agree. That logo just shows too many small details for being used as an icon.

avatar dgrammatiko
dgrammatiko - comment - 10 Oct 2020

Please use SVG for the icon as anything non vector will always be crappy in some scenarios.
Copy paste the icon from here:
https://iconify.design/icon-sets/simple-icons/webauthn.html

License : cc, so it's fine

avatar N6REJ
N6REJ - comment - 11 Oct 2020

well, took a while to get everything "perfect" but I think we got there as far as using an icon goes.
as for removing it, you'd need to ask someone far higher up the food chain then me if thats ok.
image

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020

If the icon is staying, then the great job you have done now gets a thumbs up from me and is a lot better than the first black logo attempt.

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020

Just another Sunday question - why are we using a black version of the joomla logo instead of the actual colour logo on the login page there? Surely the project should be using and promoting its main symbol on the main login page and not a manipulated black version. Just a thought.

avatar infograf768
infograf768 - comment - 11 Oct 2020

@PhilETaylor

why are we using a black version of the joomla logo instead of the actual colour logo

Good question...

Here is a login page with a colored svg (size can be modified)

Screen Shot 2020-10-11 at 12 08 00

avatar infograf768
infograf768 - comment - 11 Oct 2020

If you need it to replace the present svg, here it is (same size)

Screen Shot 2020-10-11 at 16 46 40

login.svg.zip

avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Category Repository NPM Change Front End Plugins Administration Templates (admin) Repository NPM Change Front End Plugins
avatar N6REJ
N6REJ - comment - 11 Oct 2020

@PhilETaylor @infograf768 done and ty for supplying the svg file

avatar dgrammatiko
dgrammatiko - comment - 11 Oct 2020

@N6REJ the sass linter expects alphabetical sorted properties...

avatar N6REJ
N6REJ - comment - 11 Oct 2020

READY FOR TESTING FINALLY

avatar N6REJ N6REJ - change - 11 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 11 Oct 2020
avatar N6REJ N6REJ - change - 11 Oct 2020
The description was changed
avatar N6REJ N6REJ - edited - 11 Oct 2020
avatar infograf768 infograf768 - change - 12 Oct 2020
The description was changed
avatar infograf768 infograf768 - edited - 12 Oct 2020
avatar infograf768 infograf768 - change - 12 Oct 2020
Title
move icon to block
[4.0] move icon to block
avatar infograf768 infograf768 - edited - 12 Oct 2020
avatar fancyFranci fancyFranci - test_item - 17 Oct 2020 - Tested successfully
avatar fancyFranci
fancyFranci - comment - 17 Oct 2020

I have tested this item successfully on fbd6854

The result is exactly like the expected one in the description


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31028.

avatar Turikhay144
Turikhay144 - comment - 17 Oct 2020

Tested logo changes to color
But I don't see the web auth button
Screenshot 2020-10-17 at 17 56 20

avatar richard67
richard67 - comment - 17 Oct 2020

@Turikhay144 The WebAuth button can only be seen when accessing the site with https. I assume you used http.

avatar jwaisner jwaisner - test_item - 19 Oct 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 19 Oct 2020

I have tested this item successfully on fbd6854


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31028.

avatar jwaisner jwaisner - change - 19 Oct 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 19 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31028.

avatar richard67 richard67 - close - 19 Oct 2020
avatar richard67 richard67 - merge - 19 Oct 2020
avatar richard67 richard67 - change - 19 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-19 21:05:24
Closed_By richard67
Labels Added: ?
avatar richard67
richard67 - comment - 19 Oct 2020

Thanks everybody who was involved.

Add a Comment

Login with GitHub to post a comment