J4 Issue ?
avatar PhilETaylor
PhilETaylor
8 Oct 2020

Steps to reproduce the issue

Go and trash two articles
Use filter options to show trashed items
Note that the "Empty Trash" button is greyed out - There is no way to purge ALL items from the trash
Select a trashed item - note now you can use "Empty Trash" button - but it only deletes the selected item and doesn't purge all trashed articles

Also, while you have a trashed item selected, click Actions button, note that Trash is a selectable action in there... but this item is ALREADY trashed!

Expected result

Empty Trash button is a purge all trashed articles button

No "Trash" Action when items are already in the trash and when filtered by trashed items.

Actual result

As explained above.

Screenshot 2020-10-08 at 22 40 08

System information (as much as possible)

Additional comments

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar PhilETaylor PhilETaylor - open - 8 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Oct 2020
avatar PhilETaylor PhilETaylor - change - 8 Oct 2020
Title
[4] Empty Trash Issues.
[4] com_content Empty Trash Issues.
avatar PhilETaylor PhilETaylor - edited - 8 Oct 2020
avatar PhilETaylor PhilETaylor - change - 8 Oct 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 Oct 2020
avatar PhilETaylor PhilETaylor - change - 8 Oct 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 Oct 2020
avatar brianteeman
brianteeman - comment - 8 Oct 2020

Note that the "Empty Trash" button is greyed out - There is no way to purge ALL items from the trash

phil

avatar PhilETaylor
PhilETaylor - comment - 8 Oct 2020

Its greyed out until you select items....

Its not a purge button, its a Trash item button and acts just like the Trash Action does... It makes no sense that its called "Empty Trash"

When I empty my trash cans, I don't take out one thing only. I tip up the trash can and empty it all... PURGE....

avatar PhilETaylor
PhilETaylor - comment - 8 Oct 2020

I see Joomla 3 has this strange behaviour too...

avatar PhilETaylor
PhilETaylor - comment - 8 Oct 2020

ok lets ignore the "Empty Trash" actually really being a "delete this item" from the db ...

The other bug in this issue remains too.

avatar PhilETaylor
PhilETaylor - comment - 8 Oct 2020

The other bug

Expected result = No "Trash" Action when items are already in the trash and when filtered by trashed items.

avatar infograf768
infograf768 - comment - 9 Oct 2020

I agree it would be nice to take of the Actions => Trash when filtered by Trashed.

In the articles view for example we could have something like

				if (Factory::getApplication()->input->get('filter')[2] !== '-2')
				{
					$childBar->trash('articles.trash')->listCheck(true);
				}

Because we get a sequential array
["filter"]=> array(5) { ["search"]=> string(0) "" ["featured"]=> string(0) "" ["published"]=> string(2) "-2" ["language"]=> string(0) "" ["level"]=> string(0) "" }

Me not php good enough to fetch by published key ;)

Screen Shot 2020-10-09 at 08 28 48

avatar HLeithner
HLeithner - comment - 11 Oct 2020

As first step can we rename "Empty Trash" to "Delete" ?

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020

That makes more sense yes, but it can also then be put into the Actions menu too, as its a normal action (unlike a purge task that it assumed it is when not in the action dropdown)

avatar HLeithner
HLeithner - comment - 11 Oct 2020

Yes I know but till someone modify the action array (because this interacts also with the workflow) a button text change in the first place would "reduce" the issue

avatar infograf768
infograf768 - comment - 11 Oct 2020

As first step can we rename "Empty Trash" to "Delete" ?

Not sure about that. Macintosh has used "Empty Trash" for ever and I have never seen any comments on forum about this wording creating confusion.

Screen Shot 2020-10-11 at 16 52 48

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020

You ARE confused and that proves my point nicely :-)

Empty trash on a mac PURGES EVERYTHING IN TRASH - you don't need to select anything

That's my point. In joomla you can safely assume Empty Trash means to PURGE EVERYTHING IN TRASH but that's NOT WHAT it does in joomla

In joomla Empty Trash button just deletes SELECTED ITEMS ONLY from the trash.

avatar infograf768
infograf768 - comment - 11 Oct 2020

yeah. after siesta confusion...

avatar infograf768
infograf768 - comment - 12 Oct 2020

Concerning the dropdown Trash choice when filtered by Trash, see #31074

avatar jwaisner jwaisner - change - 2 Nov 2020
Labels Added: J4 Issue
avatar jwaisner jwaisner - labeled - 2 Nov 2020
avatar brianteeman
brianteeman - comment - 10 May 2021

This looks like it has been resolved elsewhere - please check and confirm

avatar PhilETaylor PhilETaylor - change - 10 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-10 10:41:01
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 May 2021
avatar PhilETaylor
PhilETaylor - comment - 10 May 2021

all good. ta.

Add a Comment

Login with GitHub to post a comment