User tests: Successful: Unsuccessful:
Following up on similar layouts for Articles List and Contact lists, this one concerns the 3 Tags layouts.
Getting rid of fieldset, separating search filter from list limit. some a11y.
Deleting one redundant lang string, modifying another.
Adding a missing parameter field in xml.
Kept one layout as table, left the others as ul/li.
Create some tags. Tag some contacts and articles.
Create 3 menu items
Display in frontend
patch and test again.
Check code produced
Status | New | ⇒ | Pending |
Category | ⇒ | com_tags Front End Language & Strings |
The following markup should not be outputted when Hide
is selected for Filter Field
and Display Select
.
<form action="http://localhost/joomla-cms-4.0-dev/index.php/tagged-items" method="post" name="adminForm" id="adminForm">
<input type="hidden" name="filter_order" value="">
<input type="hidden" name="filter_order_Dir" value="">
<input type="hidden" name="limitstart" value="">
<input type="hidden" name="task" value="">
</form>
I have tested this item
I think this PR refers only to the Search bar, which did change as indicated in the screen shots.
I did notice that in menu item creation the Tag field dropdown did not list any tags and if a typed-in tag was spelled wrongly it got created. Separate issues?
The following markup should not be outputted when
Hide
is selected forFilter Field
andDisplay Select
.
@Quy
Does not break anything but, if judged important, I guess that depending on the filter display or/and the list limit, these hidden input markup display should be differentiated.
Would you be kind enough to propose mergeable patches ?
I think this PR refers only to the Search bar, which did change as indicated in the screen shots.
There is also taking of the useless fieldset and some a11y
I did notice that in menu item creation the Tag field dropdown did not list any tags and if a typed-in tag was spelled wrongly it got created. Separate issues?
Yep, totally separated.
Labels |
Added:
?
?
|
Corrected useless hidden input for markup + lang string
Left task input although it does not look necessary.
There is no change in display.
Needs another test.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
rtc
The none space between search field and list is expected?
The none space between search field and list is expected?
Yes, this has been already normalised for articles, contacts, here tags an soon newsfeeds
That looks horrible mainly because of the rounded corners but maybe the template team came up with something better @richard67
Thanks anyway
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-13 08:01:03 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
maybe the template team came up with something better
horrible
is a heavy word but, once all is normalised, it will be easier for them.
@HLeithner I'm not one of the team leads of the template team.
The styling must be made in cassiopeia. It is bad that, if this is made now in jomla cms it looks bad. So maybe we really should wait with merging until the cassiopeia PR is made?
Done.
Honestly, I'm of the opinion that the Tag Layout should match 1:1 with the Category Layouts.
Meaning these should look the same:
Category Blog = Tagged Items View
Category List = Compact Tagged Items View
I'm wondering why this is not the case?
In Wordpress, all layouts are consistent and identical for all Category view, Tag view, Author view. In Joomla they're all different and inconsistent... Why?
Could Joomla 4 be a good opportunity to uniform these layouts?
Note
I have remarked some bugs in Tags generally speaking (no surprise...), which are not related to this PR.
Basically the list items and compact list items do not consider an item which
core-state === 0
, neither publishing up or down dates and therefore the possibility for a user who$cando
only to display them when logged in.Some items although Published and set to Publish up in the future will display and when a user has no access to that item create a 404 when clicked.