? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Oct 2020

Summary of Changes

Following up on similar layouts for Articles List and Contact lists, this one concerns the 3 Tags layouts.
Getting rid of fieldset, separating search filter from list limit. some a11y.
Deleting one redundant lang string, modifying another.
Adding a missing parameter field in xml.

Kept one layout as table, left the others as ul/li.

Testing Instructions

Create some tags. Tag some contacts and articles.

Create 3 menu items

  1. Tagged Items
  2. List all tags
  3. Compact List of Tagged Items

Display in frontend
patch and test again.

Check code produced

Actual result BEFORE applying this Pull Request

  1. Tagged Items

Screen Shot 2020-10-08 at 17 34 37

  1. List all tags

Screen Shot 2020-10-08 at 17 35 03

  1. Compact List of Tagged Items

Screen Shot 2020-10-08 at 17 35 40

Expected result AFTER applying this Pull Request

  1. Tagged Items

Screen Shot 2020-10-08 at 17 31 34

  1. List all tags

Screen Shot 2020-10-08 at 17 32 47

  1. Compact List of Tagged Items

Screen Shot 2020-10-08 at 17 33 13

avatar infograf768 infograf768 - open - 8 Oct 2020
avatar infograf768 infograf768 - change - 8 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2020
Category com_tags Front End Language & Strings
avatar infograf768
infograf768 - comment - 8 Oct 2020

Note

I have remarked some bugs in Tags generally speaking (no surprise...), which are not related to this PR.
Basically the list items and compact list items do not consider an item which core-state === 0, neither publishing up or down dates and therefore the possibility for a user who $cando only to display them when logged in.

Some items although Published and set to Publish up in the future will display and when a user has no access to that item create a 404 when clicked.

avatar Quy
Quy - comment - 8 Oct 2020

The following markup should not be outputted when Hide is selected for Filter Field and Display Select.

	<form action="http://localhost/joomla-cms-4.0-dev/index.php/tagged-items" method="post" name="adminForm" id="adminForm">
				
		<input type="hidden" name="filter_order" value="">
		<input type="hidden" name="filter_order_Dir" value="">
		<input type="hidden" name="limitstart" value="">
		<input type="hidden" name="task" value="">
	</form>
avatar ceford ceford - test_item - 9 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 9 Oct 2020

I have tested this item successfully on 637291e

I think this PR refers only to the Search bar, which did change as indicated in the screen shots.

I did notice that in menu item creation the Tag field dropdown did not list any tags and if a typed-in tag was spelled wrongly it got created. Separate issues?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30998.

avatar infograf768
infograf768 - comment - 9 Oct 2020

The following markup should not be outputted when Hide is selected for Filter Field and Display Select.

@Quy
Does not break anything but, if judged important, I guess that depending on the filter display or/and the list limit, these hidden input markup display should be differentiated.
Would you be kind enough to propose mergeable patches ?

I think this PR refers only to the Search bar, which did change as indicated in the screen shots.

There is also taking of the useless fieldset and some a11y

I did notice that in menu item creation the Tag field dropdown did not list any tags and if a typed-in tag was spelled wrongly it got created. Separate issues?

Yep, totally separated.

avatar infograf768 infograf768 - change - 12 Oct 2020
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 12 Oct 2020

Corrected useless hidden input for markup + lang string
Left task input although it does not look necessary.

There is no change in display.
Needs another test.

avatar paternax paternax - test_item - 12 Oct 2020 - Tested successfully
avatar paternax
paternax - comment - 12 Oct 2020

I have tested this item successfully on 1b3b5dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30998.

avatar infograf768 infograf768 - change - 13 Oct 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 13 Oct 2020

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30998.

avatar HLeithner
HLeithner - comment - 13 Oct 2020

The none space between search field and list is expected?

avatar infograf768
infograf768 - comment - 13 Oct 2020

The none space between search field and list is expected?

Yes, this has been already normalised for articles, contacts, here tags an soon newsfeeds

avatar HLeithner
HLeithner - comment - 13 Oct 2020

That looks horrible mainly because of the rounded corners but maybe the template team came up with something better @richard67

Thanks anyway

avatar HLeithner HLeithner - change - 13 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-13 08:01:03
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 13 Oct 2020
avatar HLeithner HLeithner - merge - 13 Oct 2020
avatar infograf768
infograf768 - comment - 13 Oct 2020

maybe the template team came up with something better

horrible is a heavy word but, once all is normalised, it will be easier for them.

avatar richard67
richard67 - comment - 13 Oct 2020

@HLeithner I'm not one of the team leads of the template team.

avatar chmst
chmst - comment - 13 Oct 2020

The styling must be made in cassiopeia. It is bad that, if this is made now in jomla cms it looks bad. So maybe we really should wait with merging until the cassiopeia PR is made?

avatar richard67
richard67 - comment - 13 Oct 2020

@chmst I'll merge it to the Cassiopeia repo in the next hour.

avatar richard67
richard67 - comment - 13 Oct 2020

Done.

avatar AndySDH
AndySDH - comment - 13 Oct 2020

@infograf768

Honestly, I'm of the opinion that the Tag Layout should match 1:1 with the Category Layouts.

Meaning these should look the same:

Category Blog = Tagged Items View
Category List = Compact Tagged Items View

I'm wondering why this is not the case?

In Wordpress, all layouts are consistent and identical for all Category view, Tag view, Author view. In Joomla they're all different and inconsistent... Why?

Could Joomla 4 be a good opportunity to uniform these layouts?

Add a Comment

Login with GitHub to post a comment