Feeling Lucky
?
?
[#30990] - [4.0] codemirror height
- Fixed in Code Base
- 9 Oct 2020
- Medium
- Build: 4.0-dev
- # 30990
- Diff
- brianteeman:sk-codemirror
User tests: Successful: Unsuccessful:
Pull Request for Issue #30955 .
Summary of Changes
Port #13266 to Joomla 4
On larger screens, CodeMirror height seems small (300px) compared to the space available.
This PR...
Gives Codemirror a fluid height, increasing the working space when available.
Keeps a min-height of 400px
Ensures space remains above the fold for appending buttons (article edit)
Testing Instructions
Apply PR and open CodeMirror (template file edit, article edit)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Front End Plugins |
Quy
- comment
- 8 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30990.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 8 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30990.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-09 10:08:32 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 9 Oct 2020
thanks
brianteeman
- comment
- 9 Oct 2020
thanks
I have tested this item✅ successfully on cb1a38a
Set in Global Options Editor: Codemirror. Test on Template file, Article, Custom Module.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30990.