Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30985] - [4.0] Replace old contact icons by icons

? NPM Resource Changed ? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar chmst
chmst
7 Oct 2020

Summary of Changes

On single contact, images from about 2006 still are in use as icons.
This PR removes old contact images, replaces them by modern icons, and adds alt-text to the icons and images.
A missing icon for the homepage is added.

It is a first step - the single contact page has not been styled yet in J4 and uses old classes and a definition list.

Testing Instructions

In backend, component contact, set values in the global options, so that your contact displays as mayn informations as you want.

Actual result BEFORE applying this Pull Request

icons-contact-old

Expected result AFTER applying this Pull Request

There are missing a few icons, waiting for another PR

icons-contact

Documentation Changes Required

maybe

avatar chmst chmst - open - 7 Oct 2020
avatar chmst chmst - change - 7 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2020
Category ⇒ Administration com_contact Language & Strings Repository NPM Change Front End
avatar chmst chmst - change - 7 Oct 2020
Labels Added: ? NPM Resource Changed ?
avatar N6REJ
N6REJ - comment - 8 Oct 2020

icon-fax requires pr #30707 to be merged but its fine to have it here.

avatar adj9 adj9 - test_item - 10 Oct 2020 - Tested successfully
avatar adj9
adj9 - comment - 10 Oct 2020

I have tested this item ✅ successfully on ed9e122

I create a contact list from the root menu and it works.
Schermata 2020-10-10 alle 12 48 24

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30985.
avatar sandewt
sandewt - comment - 10 Oct 2020

You could also make the icons muted. Improvement? See elsewhere on the [4.0] site.

screen shot 2020-10-10 at 12 42 53

Code something like this:
class="text-muted icon-address"

[EDIT]

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30985.
avatar chmst
chmst - comment - 10 Oct 2020

Here it is more to get rid of the old fashioned images. Styling is task of cassiopeia or the frontend template.

avatar richard67 richard67 - test_item - 15 Oct 2020 - Tested successfully
avatar richard67
richard67 - comment - 15 Oct 2020

I have tested this item ✅ successfully on ed9e122

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30985.

avatar richard67 richard67 - change - 15 Oct 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 15 Oct 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30985.

avatar drmenzelit drmenzelit - change - 15 Oct 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-15 11:55:01
Closed_By ⇒ drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 15 Oct 2020
avatar drmenzelit drmenzelit - merge - 15 Oct 2020
avatar drmenzelit
drmenzelit - comment - 15 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment