Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30979] - Undefined constant on PHP 5.3

? ? Pending

User tests: Successful: 3 ChristineWk, degobbis, gostn Unsuccessful: 0

avatar SharkyKZ
SharkyKZ
7 Oct 2020

Summary of Changes

SORT_NATURAL is not available on PHP 5.3.

Testing Instructions

Use PHP 5.3.
Go to template file list in backend.

Actual result BEFORE applying this Pull Request

Many PHP notices and warnings:

Notice: Use of undefined constant SORT_NATURAL - assumed 'SORT_NATURAL' in administrator\components\com_templates\views\template\tmpl\default_tree.php on line 11
Warning: ksort() expects parameter 2 to be long, string given in administrator\components\com_templates\views\template\tmpl\default_tree.php on line 11

Expected result AFTER applying this Pull Request

No PHP notices/warnings.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 7 Oct 2020
avatar SharkyKZ SharkyKZ - change - 7 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2020
Category ⇒ Administration com_templates
avatar SharkyKZ SharkyKZ - change - 7 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 7 Oct 2020
avatar N6REJ
N6REJ - comment - 9 Oct 2020

we have a pr #31009

avatar N6REJ N6REJ - change - 9 Oct 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-09 01:41:10
Closed_By ⇒ N6REJ
Labels Added: ?
avatar N6REJ N6REJ - close - 9 Oct 2020
avatar SharkyKZ
SharkyKZ - comment - 9 Oct 2020

This is the PR.

avatar SharkyKZ SharkyKZ - change - 9 Oct 2020
Status Closed ⇒ New
Closed_Date 2020-10-09 01:41:10 ⇒
Closed_By N6REJ ⇒
avatar SharkyKZ SharkyKZ - change - 9 Oct 2020
Status New ⇒ Pending
avatar SharkyKZ SharkyKZ - reopen - 9 Oct 2020
avatar N6REJ
N6REJ - comment - 9 Oct 2020

@SharkyKZ why not continue to use ksort? Whats the reason to change to some other method? Sort Natural IS available, but you must use an integer as I stated in my PR which in this case is "4".

avatar gostn gostn - test_item - 10 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 10 Oct 2020

I have tested this item ✅ successfully on cf75f13

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30979.

avatar ChristineWk ChristineWk - test_item - 17 Oct 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 17 Oct 2020

J 3.9.22 > I have tested this item ✅ successfully on cf75f13

Everything works as well as before.
Datenbankversion 5.7.31-log
Datenbankzeichensatz utf8_general_ci
Datenbankverbindungszeichensatz utf8mb4_general_ci
PHP-Version 7.3.22
Webserver Apache
PHP-Interface für den Webserver cgi-fcgi

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30979.

avatar alikon alikon - change - 17 Oct 2020
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 17 Oct 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30979.

avatar zero-24
zero-24 - comment - 17 Oct 2020

I'm adding the milestone but let @HLeithner merge it himself as he assigned it to himself.

avatar degobbis degobbis - test_item - 17 Oct 2020 - Tested successfully
avatar degobbis
degobbis - comment - 17 Oct 2020

I have tested this item ✅ successfully on cf75f13

Tested with PHP 8.0.0rc1
Error reporting: develper

No errors, warnings or notices.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30979.

avatar HLeithner HLeithner - change - 17 Oct 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-17 15:55:59
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 17 Oct 2020
avatar HLeithner HLeithner - merge - 17 Oct 2020
avatar HLeithner
HLeithner - comment - 17 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment