User tests: Successful: Unsuccessful:
Pull Request for Issue #30929 .
This pull request (PR) adds the necessary SQL statements to delete the duplicate record for plg_sampledata_multilang in the extension table to the update SQL scripts.
I order to not add again a new update SQL script, I've decided to modify the existing script 4.0.0-2020-09-27.sql, which hasn't been released yet and so can be modified, as we don't support updates between nightlies.
If a new Beta or whatever else release of J4 will be made before this PR will be merged, I'll have to move the new statement to a new update SQL script then.
In addition, this PR deletes the update SQL script 4.0.0-2018-06-11.sql
which causes the duplicate record. In fact the other one 4.0.0-2019-03-31.sql
which was added later with commit fc0d2ea#diff-97d026690fd483a67b57a74953ef4a50 caused the problem, but because no other SQL script in between those references the record for that plugin, it doesn't matter which of the duplicate insert statements is deleted, and so I've chosen the first one because 1. it saves us a complete update SQL script, and 2. the deleted one had the wrong "enabled" status.
This test has to be executed after the previous test "Test 1".
Result: There is only one plugin with name "Sample Data - Multilingual", which is enabled. The first one of the two duplicate plugins has been deleted.
Repeat test "Test 1", i.e. start again from 3.10, but this time use the update package of latest 4.0 nightly plus the fix of this PR included. The custom update URL and the download package are the same as used in the previous test "Test 2".
Result: There is only one plugin with name "Sample Data - Multilingual", which is enabled.
After an update from 3.10 to 4, there are two plugins with name "Sample Data - Multilingual". They are equal, except one of them is disabled.
After an update from 3.10 to 4, there is only one plugin with name "Sample Data - Multilingual", which is enabled.
After update from a 4 Beta 4 which had the issue to a future 4 version which contains the fix from this PR, one of the duplicate plugins "Sample Data - Multilingual" will be deleted.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql |
Title |
|
Labels |
Added:
?
|
@brianteeman Would be great if you could find some time to give this PR a test. Thanks in advance.
I have tested this item
@brianteeman I'm a bit disappointed that you don't test PR's for issues opened by you. Or is it just when I am the PR author?
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-16 22:55:31 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Thanks for testing and merging.
I've just noticed that this PR causes an SQL error when updating e.g. 4.0 Beta 4 to latest nightly on MySQL, and very likely also on MariaDB.
The reason is that MySQL can't handle a subquery on the same table in an UPDATE or DELETE statement.
Will check if that's a problem with PostgreSQL, too, and then make a PR to fix it.
No idea why that hasn't shown up when testing.
Other database types, e.g. MS SQL server and Oracle, can handle that, just by the way.
Update: Not a problem on PostgreSQL.
I've just fixed a few things in the testing instructions. Now it's really ready for testing.