User tests: Successful: Unsuccessful:
Pull Request for Issue #30928 .
This pull request (PR) adds the necessary SQL statements to delete the obsolete record for plg_authentication_gmail in the extension table to the update SQL scripts.
I order to not add again a new update SQL script, I've decided to modify the existing script 4.0.0-2020-09-27.sql, which hasn't been released yet and so can be modified, as we don't support updates between nightlies.
If a new Beta or whatever else release of J4 will be made before this PR will be merged, I'll have to move the new statement to a new update SQL script then.
If my other PR #30945 which updates the same SQL scripts is merged before this one, I have to solve conflicts here before this one can be merged.
Repeat the previous test "Test 1", but this time use the update package of latest 4.0 nightly plus the fix of this PR included.
Result: The plugin doesn't exists, see also section "Expected result AFTER applying this Pull Request" below.
Repeat the previous test "Test 2", but this time don't start from a 3.10 installation.
Start from an installation of 4.0 Beta 4 instead.
It has to be 4.0 Beta 4 and not current 4.0-dev or latest 4.0 nighty.
Result: The plugin doesn't exists, see also section "Expected result AFTER applying this Pull Request" below.
After an update from 3.10 to 4, there is still an authentication plugin with name "plg_authentication_gmail" in the extensions table in database and so in the list of plugins in backend.
Trying to uninstall that results in an error "Call to a member function attributes() on null".
After an update from 3.10 to 4, there is no authentication plugin with name "plg_authentication_gmail" in the extensions table in database and in the list of plugins in backend.
After update from a 4 Beta version which had the issue to a future 4 version which contains the fix from this PR, the obsolete authentication plugin "plg_authentication_gmail" will be deleted.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-08 09:19:32 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
?
?
|
Thanks!
Thanks for testing and merging.
I have tested this item✅ successfully on 6181df9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30941.