? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Oct 2020

Enable language debug
Open an article
On the save button dropdown you will see ??**Save to Menu**??

Apply the PR
Now the button is correctly displayed as **Save to Menu**

image

avatar brianteeman brianteeman - open - 6 Oct 2020
avatar brianteeman brianteeman - change - 6 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2020
Category Administration com_content
avatar infograf768
infograf768 - comment - 6 Oct 2020

This is one solution.
The other is to modify ToolbarHelper and add 'save2menu' => 'JTOOLBAR_SAVE_TO_MENU', in the saveGroup method.

What do you think?

avatar brianteeman
brianteeman - comment - 6 Oct 2020

I didnt see that - that would be much better. Closing this one here - can you make the PR?

avatar brianteeman brianteeman - change - 6 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-06 08:40:54
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 6 Oct 2020
avatar infograf768
infograf768 - comment - 6 Oct 2020

k

avatar infograf768
infograf768 - comment - 6 Oct 2020

Please reopen. My solution does not work.

avatar brianteeman brianteeman - change - 6 Oct 2020
Status Closed New
Closed_Date 2020-10-06 08:40:54
Closed_By brianteeman
avatar brianteeman brianteeman - change - 6 Oct 2020
Status New Pending
avatar brianteeman brianteeman - reopen - 6 Oct 2020
avatar infograf768 infograf768 - test_item - 6 Oct 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 6 Oct 2020

I have tested this item successfully on c189bae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

avatar gostn gostn - test_item - 6 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 6 Oct 2020

I have tested this item successfully on c189bae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

avatar infograf768 infograf768 - change - 6 Oct 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 6 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

avatar gostn
gostn - comment - 6 Oct 2020

are ´??´always be reported? Like:

image

avatar brianteeman
brianteeman - comment - 6 Oct 2020

We already have an issue open for that one #24168

avatar infograf768 infograf768 - change - 6 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-06 10:10:10
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 6 Oct 2020
avatar infograf768 infograf768 - merge - 6 Oct 2020
avatar infograf768
infograf768 - comment - 6 Oct 2020

Tks.

avatar brianteeman
brianteeman - comment - 6 Oct 2020

thanks

Add a Comment

Login with GitHub to post a comment