Joomla! Issue Tracker | Joomla! CMS #30929 - [4.0] Sample Data multingual

Closed
6 Oct 2020
Medium
Build: staging
# 30929

brianteeman
5 Oct 2020

Steps to reproduce the issue

Upgrade joomla 3.10alpha to joomla 4beta

Expected result

there is ONE multilingual sample data plugin

Actual result

Two are listed

Cause

This is because there are two database records for the plugin in #__extensions

Perhaps caused by having both

joomla-cms/administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-06-11.sql

Lines 1 to 4 in c4db467

    
           INSERT INTO `#__extensions` 
        
           (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) 
        
           VALUES 
        
             (0, 'plg_sampledata_multilang', 'plugin', 'multilang', 'sampledata', 0, 0, 1, 0, '', '', '', 0, '0000-00-00 00:00:00', 0, 0);

joomla-cms/administrator/components/com_admin/sql/updates/mysql/4.0.0-2019-03-31.sql

Lines 1 to 3 in c4db467

    
           INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES 
        
           (0, 'plg_sampledata_multilang', 'plugin', 'multilang', 'sampledata', 0, 1, 1, 0, '', '{}', '', 0, '0000-00-00 00:00:00', 0, 0), 
        
           (0, 'plg_installer_webinstaller', 'plugin', 'webinstaller', 'installer', 0, 1, 1, 0, '', '{}', '', 0, '0000-00-00 00:00:00', 0, 0);

brianteeman - open - 5 Oct 2020

joomla-cms-bot - change - 5 Oct 2020

Labels

Added: ?

joomla-cms-bot - labeled - 5 Oct 2020

infograf768 - comment - 6 Oct 2020

Looks like the first one should be deleted

richard67 - comment - 6 Oct 2020

Since both of the update SQL scripts are from before Beta 1 and so from before our update promise, we can just delete one of the 2 duplicate insert statements. I assume the one in 4.0.0-2018-06-11.sql where it has wrong enabled status.

In addition, we need a new update SQL for updating previous Beta versions to the future Beta which will contain the fix for this issue. The SQL needs to be a bit clever, it needs to get the lowest of the IDs of the duplicate records to delete that one. I can help with that if necessary. Maybe I can later make a PR even, but right now I don't have the time.

richard67 - comment - 6 Oct 2020

I'll work on it.

richard67 - comment - 6 Oct 2020

The 2nd plugin has been added with commit fc0d2ea#diff-97d026690fd483a67b57a74953ef4a50 .. it seems that was a mistake.

richard67 - comment - 6 Oct 2020

Closing as having a pull request. Please test #30945 .

richard67 - change - 6 Oct 2020

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2020-10-06 18:54:09
Closed_By		⇒	richard67

richard67 - close - 6 Oct 2020

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#30929] - [4.0] Sample Data multingual - twice

Steps to reproduce the issue

Expected result

Actual result

Cause

Add a Comment

	INSERT INTO `#__extensions`
	(`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`)
	VALUES
	(0, 'plg_sampledata_multilang', 'plugin', 'multilang', 'sampledata', 0, 0, 1, 0, '', '', '', 0, '0000-00-00 00:00:00', 0, 0);

	INSERT INTO `#__extensions` (`package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES
	(0, 'plg_sampledata_multilang', 'plugin', 'multilang', 'sampledata', 0, 1, 1, 0, '', '{}', '', 0, '0000-00-00 00:00:00', 0, 0),
	(0, 'plg_installer_webinstaller', 'plugin', 'webinstaller', 'installer', 0, 1, 1, 0, '', '{}', '', 0, '0000-00-00 00:00:00', 0, 0);