?
avatar brianteeman
brianteeman
5 Oct 2020

Steps to reproduce the issue

Upgrade joomla 3.10alpha to joomla 4beta

Expected result

com_search and its plugins and modules are still present - the docs say there will be an update site for this now uncoupledextension.

I should alternatively be able to uninstall the component and its associated plugins and modules

Actual result

Create a new module
image

Oh that looks strange it says mod_search not Search - never mind create the module anyway
image

Go to Extensions: Manage
image

Oh that looks strange it says mod_search not Search - never mind uninstall it anyway
image

Explanation

During the second stage of the update this script is run administrator/components/com_admin/script.php which is for removing files

It is removing the code and language file for mod_search

As nothing else for the search component is removed then this probably should not be removed either. OR if it is going to be removed then all of search should be removed INCLUDING the sql record in #__extensions

This record in #__extensions is what is creating the phantom record in the list of extensions

avatar brianteeman brianteeman - open - 5 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Oct 2020
avatar brianteeman brianteeman - change - 5 Oct 2020
The description was changed
avatar brianteeman brianteeman - edited - 5 Oct 2020
avatar richard67
richard67 - comment - 6 Oct 2020

As far as I understand we should not delete the record in database and also not delete the files and folders because com_search might be present when updating, except that the maintainers of com_search decide to keep completely separate versions for J3 and J4 without any migration path, so the J3 component has to be removed. But I don't think that's the way to go.

So PR #25559 has to be extended by ignoring the com_search files and folders when creating the list of files and folders to be deleted for adding that to script.php. => Ping @wilsonge .

avatar brianteeman
brianteeman - comment - 3 Jan 2021

@wilsonge ping again

avatar wilsonge wilsonge - change - 3 Jan 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-01-03 01:25:33
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Jan 2021
avatar wilsonge
wilsonge - comment - 3 Jan 2021

Manually patched the script.php for now (see linked commit). Also added it into my PR here #25559 for future regenerations of the script items

avatar wilsonge
wilsonge - comment - 3 Jan 2021

Also thanks for the reping!

avatar brianteeman
brianteeman - comment - 3 Jan 2021

Thanks @wilsonge

Add a Comment

Login with GitHub to post a comment