Feeling Lucky
?
[#30920] - FoF and PHP 8
- Closed
- 5 Oct 2020
- Medium
- Build: staging
- # 30920
FoF has an error on PHP 8 caused by incompatible function signature:
If we add the missing argument, this fixes the error for us but classes extending FOFLayoutHelper remain broken unless they add it as well.
Another option is to break class inheritance and inline Joomla\CMS\Layout\LayoutHelper into FOFLayoutHelper. It's technically a B/C break but should be less painful.
joomla-cms-bot
- | Labels |
Added:
?
|
||
SharkyKZ
- comment
- 5 Oct 2020
Looking more into it, inlining could be problematic because of static $defaultBasePath property.
HLeithner
- comment
- 5 Oct 2020
hmm that's true so we have to extend the parameter, it also is only a problem for extensions want to support php8 correct?
SharkyKZ
- comment
- 5 Oct 2020
It causes an error only on PHP 8. On older versions it emits either a warning or strict standards notice.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-05 07:23:00 |
| Closed_By | ⇒ | SharkyKZ |
Adding the parameter would be the proper way but since our FOF version is deprecated anyway and people have to migrate way from it (native or new version) it seems better for j3 to inline the debug function and remove the inheritance