[#30907] - [4.0] Small refactor of typehint check in CMSPlugin
- Fixed in Code Base
- 8 Oct 2020
- Medium
- Build: 4.0-dev
- # 30907
- Diff
- SharkyKZ:j4/impr/event-typehint
User tests: Successful: Unsuccessful:
Summary of Changes
Follow up to #30581.
Renames poorly named checkTypeHint() method and makes it private.
Changes it to accept ReflectionParameter instead of ReflectionType to maintain the whole parameter logic inside.
Testing Instructions
Test that Joomla and plugins still work.
Documentation Changes Required
No, unless the method was documented somewhere.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Yes, as long as it's working as before it's fine.
I have tested this item
I applied th patch and checked Joomla still works - it does. I put a die; in the new function to check it is being called - it is. All good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907.
I have tested this item
Tested, Joomla continued working.
Hard to find a plugin that the test would either fail for before the test. Harder to find one that would fail for Joomla 4 after the test without writing one. Plugins where parameters are not typehinted I would imagine are unusual?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-08 09:21:08 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!
I have not tested this item.
With PR enabled the plugins are active and do not remain. I logged out and logged in from the administrative panel and there are no anomalies.
With these tests, can I confirm the PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30907.