[#30904] - [4.0] Frontend: Fix List Contacts Category List Limit
- Fixed in Code Base
- 8 Oct 2020
- Medium
- Build: 4.0-dev
- # 30904
- Diff
- infograf768:4.0_contact_cat_list_limit
User tests: Successful: Unsuccessful:
Pull Request for Issue #30813 (comment)
Summary of Changes
The existing code prevents modifying the list limit as it is forced or by the Global Contacts List Layout Options, or the List Contacts in a Category menu item params.
This normalizes the use of list limit, as done for other lists displaying in frontend, by deleting both fields and modifying the model code. Default is set to 20.
Testing Instructions
Create some contacts in a category.
Create a List Contacts in a Category menu item.
Display the menu item in frontend.
Try to modify the list limit
Patch and test again.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30904.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30904.
| Labels |
Added:
?
?
?
|
||
Sorry why should we hard code the default to 20? and what's the problem with our configuration option? don*t we use the same functionality in com_content?
It is not hard coded to 20. It uses the list_limit defined in global configuration. But as also shown below I dont get the same layout - and shouldnt the button be called search not filter?
I only looked at the code
- $limit = $app->getUserStateFromRequest('global.list.limit', 'limit', $app->get('list_limit'), 'uint');
+ $limit = $app->input->get('limit', $app->get('list_limit', 20), 'uint');and getuserstatefromrequest should do the same as input->get but also set the user preference in the session.
Edit: I miss read this as remove of the default, but it removes the com_contact .xml options if i'm not wrong?
don*t we use the same functionality in com_content?
Nope. We do not have a articles__num as Options in the xmls for articles List Layouts
The contact specific field option in the xmls (contacts_display_num) are unecessary as it is only used to force a specific limit which is ALWAYS set, which created the original issue
before the patch we had in Contacts CategoryModel:
$numberOfContactsToDisplay = $mergedParams->get('contacts_display_num');
if ($format === 'feed')
{
$limit = $app->get('feed_limit');
}
elseif (isset($numberOfContactsToDisplay))
{
$limit = $numberOfContactsToDisplay; // As this is always set, it forces that limit...
}
else
{
$limit = $app->getUserStateFromRequest('global.list.limit', 'limit', $app->get('list_limit'), 'uint');
}
20 is indeed basically a default.
Same code is used for frontend Articles Model concerning the category list.
joomla-cms/components/com_content/src/Model/ArticlesModel.php
Lines 94 to 95 in 06fe4d2
and shouldnt the button be called search not filter?
That's what it is called for articles list.
COM_CONTENT_FORM_FILTER_SUBMIT="Filter"I have not changed this. Just mimicked it for contacts by using a Global string
JGLOBAL_FILTER_BUTTON. It can be modified globally for all similar lists in frontend by using JSEARCH_FILTER_SUBMIT if desired.I remind you that you tested that PR OK and the layout does not change with this patch. It should be tested with a 4.0-dev test site where npm ci has been run.
#30813 (comment)
Folks, I basically have done all these contacts related frontend list refactoring PRs based on what we already have for articles.
For example, there is a debate here about the use of a fieldset or not.
#30868
Taking out the fieldset element would also change the display, pushing the list limit to the right for the contacts lists. Articles may need more refactoring.
| Labels | |||
As requested modified to use back getUserStateFromRequest
No change in behavior.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30904.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30904.
@HLeithner
Good to go.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-08 08:23:43 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 5d62196
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30904.