? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
3 Oct 2020

Pull Request for Issue #30886

Summary of Changes

Make sure hsts is only added on https sites

Testing Instructions

  • install 4.x on a http site (localhost for example)
  • enable hsts from the plugin
  • notice it is added to the header
  • apply this patch
  • see its gone
  • install this patch on a https site
  • make sure the hsts header is still added

Actual result BEFORE applying this Pull Request

HSTS is added on http sites

Expected result AFTER applying this Pull Request

HSTS is only added on https site.

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 3 Oct 2020
avatar zero-24 zero-24 - change - 3 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2020
Category Front End Plugins
avatar richard67 richard67 - test_item - 4 Oct 2020 - Tested successfully
avatar richard67
richard67 - comment - 4 Oct 2020

I have tested this item successfully on 48eee3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

avatar hans2103 hans2103 - test_item - 5 Oct 2020 - Tested successfully
avatar hans2103
hans2103 - comment - 5 Oct 2020

I have tested this item successfully on 48eee3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

avatar Quy Quy - change - 5 Oct 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30902.

avatar HLeithner HLeithner - close - 6 Oct 2020
avatar HLeithner HLeithner - merge - 6 Oct 2020
avatar HLeithner
HLeithner - comment - 6 Oct 2020

thanks

avatar HLeithner HLeithner - change - 6 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-06 08:16:52
Closed_By HLeithner
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment