User tests: Successful: Unsuccessful:
Pull Request for Issue #29742.
Edit the login module
Set Display Labels
= text
Go to front end
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
Labels |
Added:
?
|
I have tested this item
Layout issue that the PR is designed to resolve is corrected by the PR.
That said, looking at the code, I agree with @brianteeman, and the entire Login Form module is missing accessibility attributes for all the fields, so that's something for a different PR.
Additionally, I noticed for the first time today the "Web Authentication" button after turning on Two Factor Authentication to test this PR. Like 2FA, should this also not be turned on by default when Joomla 4 is installed? If it shouldn't, another PR.
I agree with @brianteeman that the title attribute is contra a11y. You can add a tooltip instead.
I have tested this item
Done :)
OK!
You can add a tooltip instead.
Tooltips don't show on iPad Safari and probably not on Android devices not using a mouse, either.
Tested successfully
I agree with @brianteeman that the title attribute is contra a11y. You can add a tooltip instead.
@brianteeman @chmst Does it mean we should not set this PR to RTC? Or does it mean it should be changed with another, future PR?
who care on drafts having two successfully test?
Sorry I don't have much time these days to contribute.
@gostn Accessibility to be fixed per Brian #30897 (comment)
See joomla-extensions/patchtester#286 regarding Draft status.
conflicts
Labels |
Added:
Conflicting Files
|
I have tested this item
When the Cassiopeia updates were proposed in PR #31520 there was a comment (I can't find it now) suggesting that the checkbox size (next to 'remember me') was enlarged. I suggested the following code and now also include the RTL version. Perhaps this could be included with this PR if suitable?
/* ltr */
.com-users-login fieldset .control-label { margin-left: 2rem; }
.com-users-login fieldset input[type="checkbox"].inputbox { position: relative; transform: scale(1.5); top: -2rem; }
/* rtl */
.com-users-login fieldset .control-label { margin-right: 2rem; }
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
@Scrabble96 Thank you for the code. It should be done in a separate PR since it is not related.
This PR fixes the alignment only. Let's fix the ay11 issue in a separate PR.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-06 19:20:27 |
Closed_By | ⇒ | drmenzelit | |
Labels |
Added:
?
Removed: Conflicting Files |
Thanks
using title to display help text is not only ugly but its not accessible