Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30890] - [4.0] size of the template name font in module position selector

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Oct 2020

PR for #30844

The heading should be visibly disabled larger than the items

before

image

after

image

testing

dont forget npm ci or node build.js --compile-css

avatar brianteeman brianteeman - open - 2 Oct 2020
avatar brianteeman brianteeman - change - 2 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2020
Category ⇒ Administration Templates (admin) NPM Change Front End Templates (site)
avatar Scrabble96
Scrabble96 - comment - 3 Oct 2020

I have tested this successfully but I don't know how to add a green tick/check mark or reference the commit. Sorry.

avatar adj9 adj9 - test_item - 3 Oct 2020 - Not tested
avatar adj9
adj9 - comment - 3 Oct 2020

I have not tested this item.

I tried but visually I do not notice any difference. I cannot apply npm.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

avatar Scrabble96
Scrabble96 - comment - 3 Oct 2020

I have not tested this item.

I tried but visually I do not notice any difference. I cannot apply npm.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

I didn't do anything with npm ci or node build.js -- complile-css either.

I tested this by using the PR zip update package which I got by clicking on 'Show all checks' next to "Some checks haven't completed yet" then selecting 'Details' next to "Download - prebuilt packages are available for download" then downloaded the update package zip, installed it on my test site and then looked at the module positions. I saw exactly as @brianteeman has shown in his screenshots. As I said above, though, I don't know how to confirm this as a successful test. If you can tell me I'd be very grateful.

avatar brianteeman
brianteeman - comment - 3 Oct 2020

Record your test here https://issues.joomla.org/tracker/joomla-cms/30890.

avatar Scrabble96 Scrabble96 - test_item - 4 Oct 2020 - Tested successfully
avatar Scrabble96
Scrabble96 - comment - 4 Oct 2020

I have tested this item ✅ successfully on 0b1dce0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30890.

avatar Scrabble96
Scrabble96 - comment - 4 Oct 2020

Record your test here https://issues.joomla.org/tracker/joomla-cms/30890.

Thank you :-)

avatar HLeithner
HLeithner - comment - 4 Oct 2020

@adj9 you can always use the prebuilt packages to test an pr like this.

image

avatar HLeithner HLeithner - close - 4 Oct 2020
avatar HLeithner HLeithner - merge - 4 Oct 2020
avatar HLeithner HLeithner - change - 4 Oct 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-04 13:31:54
Closed_By ⇒ HLeithner
Labels Added: NPM Resource Changed ?
avatar HLeithner
HLeithner - comment - 4 Oct 2020

Tested by my self thanks

avatar brianteeman
brianteeman - comment - 4 Oct 2020

thanks

Add a Comment

Login with GitHub to post a comment