Feeling Lucky
NPM Resource Changed
?
?
[#30855] - [4.0] Share image link
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 30855
- Diff
- brianteeman:yk14
User tests: Successful: Unsuccessful:
Steps to reproduce the issue
Go to media manager in admin, select an image and select to get the shareable link.
click "Get shareable link"
Expected result
When clicking the copy button, the left border doesn't disappear
Actual result
left border of the copy button disappears on click, and on any click/selection of the actual url
Pull Request for Issue #29331
Testing Instructions
npm ci or node build.js --compile-css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
brianteeman
- comment
- 2 Oct 2020
No. One PR for one task
dgrammatiko
- comment
- 2 Oct 2020
No. One PR for one task
I didn't meant to do it in this PR
Quy
- comment
- 8 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30855.
jwaisner
- comment
- 13 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30855.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 13 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30855.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 17:04:23 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 15 Oct 2020
Thanks!
brianteeman
- comment
- 15 Oct 2020
thanks
@brianteeman since you're fixing this part of the media manager could you also transform the link tag to a checkbox for the image select as well? (apparently the a-tag has side effects, try clicking many times in the fake checkbox and observe the parent window scrolling, also it's not a11y)