Feeling Lucky
NPM Resource Changed
?
?
[#30851] - [4.0] Media Manager close preview
- Fixed in Code Base
- 3 Oct 2020
- Medium
- Build: 4.0-dev
- # 30851
- Diff
- brianteeman:yk10
User tests: Successful: Unsuccessful:
Pull Request for Issue #29434 .
Summary of Changes
Close button moved from top right of the screen and detached from the image to the top right of the image itself
Testing Instructions
npm ci
Preview any image in the media manager
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
brianteeman
- comment
- 2 Oct 2020
Thats because the image is so tiny and the filename is so long. I definitely prefer that problem than not being able to find the x in the corner
Fedik
- comment
- 2 Oct 2020
can try:
bottom: 100%;
left: 100%;
and remove top: 0; right: 0;
then it will be at top right corner of the box, outside, in theory
| Labels |
Added:
NPM Resource Changed
?
|
||
Quy
- comment
- 2 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30851.
Fedik
- comment
- 3 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30851.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 3 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30851.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-03 12:50:55 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 3 Oct 2020
thanks
HLeithner
- comment
- 3 Oct 2020
thanks
brianteeman
- comment
- 3 Oct 2020
Thank you
Filename overlaps close button.