? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Sep 2020

Summary of Changes

Adding Search Filter and Clear buttons to the List Contacts in a Category menu item.
Modify the placeholder string to specify the search is limited to the Contact Title.

Testing Instructions

Create multiple contacts in the same category.
Create a List Contacts in a Category menu item for this category.
Make sure Filter Field is set to Show in the menu parameters.
Display the menu item in frontend.

Actual result BEFORE applying this Pull Request

Screen Shot 2020-09-30 at 12 53 06

Expected result AFTER applying this Pull Request

contact-search

Note

  1. With a similar PR, we can add a Clear filter button in the List Articles in a Category menu item
  2. It would be nice to add css for the Clear button in order to display a different color when the filter field is empty and not. I guess this would be for the Cassiopea Team to deal with.
avatar infograf768 infograf768 - open - 30 Sep 2020
avatar infograf768 infograf768 - change - 30 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2020
Category Repository NPM Change Front End com_contact
avatar infograf768 infograf768 - change - 1 Oct 2020
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2020
Category Repository NPM Change Front End com_contact Repository NPM Change Front End com_contact Language & Strings
9da66d3 1 Oct 2020 avatar infograf768 a11y
avatar infograf768 infograf768 - change - 1 Oct 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 1 Oct 2020

Thanks for that last change to use sr-only - I was about to comment and got distracted

avatar brianteeman brianteeman - test_item - 1 Oct 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Oct 2020

I have tested this item successfully on 9da66d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

avatar infograf768
infograf768 - comment - 1 Oct 2020

Note:
1.

Thanks for that last change to use sr-only - I was about to comment and got distracted

We will need to do the same for articles list. Will modify that in the new PR if this PR is accepted and merged.

  1. We have to be able to modify the number of items displayed in the list by using the limit box.
    It is impossible right now because the code forces $limit value to the parameters set in contact Options and the menu item, contrary to articles.
    I have a patch for that. Will propose later.
avatar jwaisner jwaisner - test_item - 1 Oct 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 1 Oct 2020

I have tested this item successfully on 9da66d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

avatar jwaisner jwaisner - change - 1 Oct 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 1 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30813.

avatar wilsonge wilsonge - change - 2 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-02 01:30:21
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Oct 2020
avatar wilsonge wilsonge - merge - 2 Oct 2020
avatar wilsonge
wilsonge - comment - 2 Oct 2020

Thanks!

avatar infograf768
infograf768 - comment - 3 Oct 2020

Concerning the list limit issue, please test #30904

Add a Comment

Login with GitHub to post a comment