[#30800] - [4.0] Replace file_exists() where applicable
- Fixed in Code Base
- 29 Sep 2020
- Medium
- Build: 4.0-dev
- # 30800
- Diff
- SharkyKZ:j4/impr/file-exists
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Replaces file_exists() checks with more suitable is_file() and is_dir(), e.g. to avoid including directories as PHP files.
Testing Instructions
Browse around, do some Joomla things.
Expected result AFTER applying this Pull Request
Still works.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on ae66656
System Information
php: Linux orion 5.4.0-48-generic #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020 x86_64
dbserver: mysql
dbversion: 8.0.21-0ubuntu0.20.04.4
dbcollation: utf8mb4_0900_ai_ci
dbconnectioncollation: utf8mb4_0900_ai_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.4.3
server: Apache/2.4.41 (Ubuntu)
sapi_name: apache2handler
version: Joomla! 4.0.0-beta4 Beta [ Mañana ] 15-September-2020 13:46 GMT
useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30800.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30800.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-29 15:51:27 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
|
||
Merging thanks.
I have tested this item✅ successfully on ae66656
I browsed around with no problems. Noted there are 294 instances of file_exists before and 235 after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30800.